CCIP-019: PoX 4 update #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoabuddy
requested changes
May 12, 2024
There was a problem hiding this comment.
Thanks for the PR! Added my comments following the review of citycoins/protocol#67 in tandem.
Co-authored-by: Jason Schrader <[email protected]>
fix references
…nto feat/add-ccip-019
Update CCIP-019 text
whoabuddy
approved these changes
Aug 7, 2024
|
I think we're good to go on the proposal side, next up will be fixing a few things in the implementation per this comment. Going to leave this open and give it a final once-over once contract is ready for deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CCIP ensure to continue the rules defined by the DAO by updating from pox-3 to pox-4.
Preview: https://github.com/citycoins/governance/blob/feat/add-ccip-019/ccips/ccip-019/ccip-019-mia-pox-4-stacking.md