CCIP-019 PoX-4 Stacking

[friedger]

This PR

• implements CCIP-019 as described in CCIP-019: Stacks Nakamoto Release Preparation governance#23

[whoabuddy]

Hey just gave this a once over and feels like we're part of the way there, some open questions and suggestions to match the formats of other proposals to start.

We should include a vote per CCIP-015, even if it's just with MIA and focused on the MIA treasury (see comments).

We should add tests for these new contracts which is tricky with the changes in formatting for Clarinet. I'm not a fan of disabling the old tests, but propose we try to keep this and add new tests side-by-side to ensure all expected outcomes.

[friedger]

Tests fails because we now have epoch 2.5 that is required for pox-4 that is used in the treasury-v3 contract..

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (4d8f4a2) to head (5e04323).

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #67   +/-   ##
=======================================
  Coverage   88.29%   88.29%           
=======================================
  Files          24       24           
  Lines        1657     1657           
  Branches      275      275           
=======================================
  Hits         1463     1463           
  Misses        174      174           
  Partials       20       20           

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8f4a2...5e04323. Read the comment docs.

[whoabuddy]

Tests fails because we now have epoch 2.5 that is required for pox-4 that is used in the treasury-v3 contract..

I think this has to do with using the mainnet addresses and the requirements, the .cache directory is normally hidden but we have it visible and uploaded so the GH runner doesn't have to download the contracts.

Something funny was happening at that step and I've got it working locally just updating to all testnet addresses in the code. It wouldn't let me add to this branch (probably something I'm doing) so here's the commit with the changes that got it to pass.

$ clarinet check -m Clarinet-2.5.toml 
✔ 149 contracts checked

Overall things look good here, I'll get a review going next and thank you for this!! 🙏

[whoabuddy]

Overall LGTM, one small change on the name in ccd005 and otherwise might be easier to use testnet addresses over mainnet for Clarinet.

[whoabuddy]

Suggested change

	(try! (contract-call? .ccd005-city-data add-treasury miaId .ccd002-treasury-mia-stx-stacking-v3 "stx-v3"))
	(try! (contract-call? .ccd005-city-data add-treasury miaId .ccd002-treasury-mia-stx-stacking-v3 "rewards-v3"))

Small change but makes it easier to understand purpose.

[whoabuddy]

Closing in favor of #76