hyper-boring: update to hyper 1.0.0 #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this! We'll have to wait until hyper 1.0 is fully released to merge and release this, but as soon as that happens I'm happy to cut a release. |
howardjohn
force-pushed
the
hyper-boring/adopt-hyper-1.0.0
branch
2 times, most recently
from
39798e9 to
5185311
Compare
howardjohn
force-pushed
the
hyper-boring/adopt-hyper-1.0.0
branch
from
5185311 to
969cb33
Compare
|
Hyper 1.0 is out, so this is almost ready to go. However, hyper-util is broken until hyperium/hyper-util#47 is merged |
howardjohn
force-pushed
the
hyper-boring/adopt-hyper-1.0.0
branch
2 times, most recently
from
d8e829c to
2579aaa
Compare
shahn
reviewed
Nov 16, 2023
Cargo.toml
Outdated
| hyper = { version = "0.14", default-features = false } | ||
| http = "1.0" | ||
| hyper = { version = "1.0", default-features = false } | ||
| hyper-util = { git = "https://github.com/hyperium/hyper-util" } |
There was a problem hiding this comment.
This adds a dependency on a not-released crate. Personally, I feel like the update to hyper 1.0 should wait for a release of hyper-util
There was a problem hiding this comment.
hyper-util is now published, moved to official release
howardjohn
force-pushed
the
hyper-boring/adopt-hyper-1.0.0
branch
from
2579aaa to
423c260
Compare
howardjohn
force-pushed
the
hyper-boring/adopt-hyper-1.0.0
branch
from
423c260 to
5185311
Compare
|
Unfortunately I messed this PR up and needed to reopen as #194 |
|
superseded by #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades hyper-boring to support hyper 1.0.0-rc.3. Most of this is by moving dependencies from hyper core to hyper-util, as much of the functionality we depend on has been removed from the core.