Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependendencies: bump to hyper 1.0.0 #726

Merged
merged 6 commits into from
Feb 23, 2024
Merged

dependendencies: bump to hyper 1.0.0 #726

merged 6 commits into from
Feb 23, 2024

Conversation

howardjohn
Copy link
Member

@howardjohn howardjohn commented Nov 16, 2023 •
edited
Loading

Two forks left:

This trades forks on: boring, hyper-util
For forks on: boring, tower-hyper-http-body-compat

So technically its a 1:1 tradeoff, but this is more future proof and http-body-compat is much smaller than hyper-util. IMO this is good to go for now

Fixes #805

@istio-testing
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2023
@istio-testing istio-testing added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 16, 2023
@GregHanson GregHanson mentioned this pull request Dec 12, 2023
Closed
@ilrudie
Copy link
Contributor

ilrudie commented Dec 13, 2023

Hyper boring was superseded by cloudflare/boring#194 so the closed PR shown right now isn't a blocker.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Dec 23, 2023
@istio-policy-bot istio-policy-bot added the lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. label Feb 14, 2024
@howardjohn howardjohn reopened this Feb 14, 2024
@howardjohn howardjohn marked this pull request as ready for review February 14, 2024 16:24
@howardjohn howardjohn requested a review from a team as a code owner February 14, 2024 16:24
@istio-testing istio-testing removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. needs-rebase Indicates a PR needs to be rebased before being merged labels Feb 14, 2024
@stevenctl
Copy link
Contributor

What's the reasoning for/against x.y vs x.y.z versions of deps? Just want to rely on lockfile for pinning now?

@ilrudie
Copy link
Contributor

ilrudie commented Feb 23, 2024

/retest

@istio-testing istio-testing merged commit a0d539e into istio:master Feb 23, 2024
2 of 3 checks passed
@daixiang0 daixiang0 mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenctl stevenctl stevenctl approved these changes

Assignees

@stevenctl stevenctl

Labels
lifecycle/automatically-closed Indicates a PR or issue that has been closed automatically. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fuzz/ failing to build
5 participants
@howardjohn @istio-testing @ilrudie @stevenctl @istio-policy-bot