Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make sentry optional #399

Closed
wants to merge 1 commit into from

Conversation

Grvzard
Copy link
Contributor

@Grvzard Grvzard commented Sep 25, 2024

This may introduce a breaking change for users who have sentry in their production environment.
To make this PR work, #396 has to be merged first.

@eaufavor eaufavor self-assigned this Sep 25, 2024
@drcaramelsyrup drcaramelsyrup added the WIP We are working on this feature internally label Sep 27, 2024
@eaufavor eaufavor added Accepted This change is accepted by us and merged to our internal repo dependencies Pull requests that update a dependency file and removed WIP We are working on this feature internally labels Sep 27, 2024
@Grvzard
Copy link
Contributor Author

Grvzard commented Oct 8, 2024

I just checked the commit ab1b717.
There is an oversight causing it to fail to compile in release mode:

#[cfg(not(debug_assertions))]
sentry::capture_error(&e);

should be

#[cfg(all(not(debug_assertions), feature = "sentry"))]
sentry::capture_error(&e);

You can take a look at my commit for other places that need changes.

@eaufavor
Copy link
Member

I believe that the change is fully merged into main now. Thanks

@eaufavor eaufavor closed this Oct 11, 2024
@Grvzard Grvzard deleted the grvz/upstream-2 branch October 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted This change is accepted by us and merged to our internal repo dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants