Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): solve dashboard QAs #5558

Merged

Conversation

piggggggggy
Copy link
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Jan 20, 2025
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
console ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:30am
dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 2:30am

Copy link
Contributor

🎉 @WANZARGEN and @seungyeoneeee have been randomly selected as the reviewers! Please review. 🙏

@piggggggggy piggggggggy merged commit fcf763a into cloudforet-io:feature-dashboard-middle-qa Jan 20, 2025
9 checks passed
@piggggggggy piggggggggy deleted the dashboard-qa branch January 20, 2025 03:39
piggggggggy added a commit that referenced this pull request Jan 20, 2025
* fix(variable-overlay): apply widget mode to variable more button

Signed-off-by: samuel.park <[email protected]>

* fix(dashboard): solve dashboard QAs (#5558)

* fix(group-by-field): solve selected-group-by sorting issue

Signed-off-by: samuel.park <[email protected]>

* chore: small fix

Signed-off-by: samuel.park <[email protected]>

* fix(value-mapping): temporarily remove expand button

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>

* fix(widget): solve widget QAs (#5559)

* fix(widget): edit widget loading state

Signed-off-by: samuel.park <[email protected]>

* fix(preview-table): solve wrong load issue

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>

---------

Signed-off-by: samuel.park <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pass/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant