Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[G4VECGEOM] Update geant4 to 11.1.ref09 #8742

Closed
wants to merge 2 commits into from

Conversation

iarspider
Copy link
Contributor

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

A new Pull Request was created by @iarspider for branch IB/CMSSW_13_3_X/g4_vecgeom.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2023

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a68ebf/35097/summary.html
COMMIT: b4aec55
CMSSW: CMSSW_13_3_G4VECGEOM_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8742/35097/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

[ 85%] Built target g4HepEmRun
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/g4hepem/20230309-4818fb9fd241707cd04501288d0aec8a/build'
[ 85%] Built target g4HepEmDataJsonIO
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/g4hepem/20230309-4818fb9fd241707cd04501288d0aec8a/build'
make: *** [Makefile:136: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.F1DhnS (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+g4hepem+20230309-4818fb9fd241707cd04501288d0aec8a
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.F1DhnS (%build)


@cmsbuild
Copy link
Contributor

Pull request #8742 was updated.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a68ebf/35125/summary.html
COMMIT: f64bfa7
CMSSW: CMSSW_13_3_G4VECGEOM_X_2023-10-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/8742/35125/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building:

make[2]: *** [DDG4/CMakeFiles/DDG4.dir/build.make:174: DDG4/CMakeFiles/DDG4.dir/src/Geant4Converter.cpp.o] Error 1
make[2]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-fd07fd5d50792f1e63166290bfd9f19c/build-g4'
make[1]: *** [CMakeFiles/Makefile2:1905: DDG4/CMakeFiles/DDG4.dir/all] Error 2
make[1]: Leaving directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/BUILD/el8_amd64_gcc11/external/dd4hep/v01-25x-fd07fd5d50792f1e63166290bfd9f19c/build-g4'
make: *** [Makefile:146: all] Error 2
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RmdgGL (%build)


RPM build errors:
line 37: It's not recommended to have unversioned Obsoletes: Obsoletes: external+dd4hep+v01-25x-fd07fd5d50792f1e63166290bfd9f19c
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.RmdgGL (%build)


@civanch
Copy link
Contributor

civanch commented Oct 11, 2023

@iarspider , Thanks for this test. It turned out that the most recent update of Geant4 requires update of DD4hep as well. We need to figure out what can be done now.

@civanch
Copy link
Contributor

civanch commented Oct 11, 2023

The fix is provided for DD4hep AIDASoft/DD4hep#1176
I am not sure if we can check it in easy way. I ask them for reference version.

@iarspider
Copy link
Contributor Author

please test

@iarspider
Copy link
Contributor Author

please abort

@smuzaffar
Copy link
Contributor

changes from geant4 branch will be forward port to vecgeom branch

@smuzaffar smuzaffar deleted the g4vecgeom-11.1.ref09 branch October 20, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants