Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes many equipment presets spawning in without a proper rank. Leading up to them showing up on the radio as ???. #7965

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Awantje
Copy link
Contributor

@Awantje Awantje commented Dec 31, 2024

Fixes many equipment presets spawning in without a proper rank. Leading up to them showing up on the radio as ???.

About the pull request

Fixes some equipment presets spawning in without a proper rank. Leading up to them showing up on the radio as ???.
For example 4 gladiator gearsets, the pizza one, a non w-y corporate representive, souto man and such.
(If you have suggestions on what gladiators/elite mercs should have as radio prefixes let me know. Now they would no longer be ??? but instead have mr or ms.)
It's mostly a bug fix. The presets that inherit from /other/ are almost all civilian or presets that have their own (custom) logic already. (mutineers and zombies). Somewhere along the line these presets ended up without a paygrade hence they would not get a rank/prefix on the radio. Instead, it would say ??? now it will say mr/ms.

Explain why it's good for the game

It's a bugfix.
#7508

Testing Photographs and Procedure

I have looked at all presets that inherit from here.
The ones that are not civilian already have properly been setup.
(Freelancers,professor dummy,a special tank crew and tank trainee.)
Mutineers/xeno cultists and zombies have their own custom logic already.
And I checked my changes ingame.

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑Awan
fix: Fixed some gearsets having improper radio/chat prefixes.
/:cl:

Fixes many equipment presets spawning in without a proper rank. Leading up to them showing up on the radio as ???.
@cmss13-ci cmss13-ci bot added the Fix Fix one bug, make ten more label Dec 31, 2024
@thevandie
Copy link
Contributor

I also made a bug report for this, like a while ago
thank you!

@harryob harryob added this pull request to the merge queue Jan 4, 2025
Merged via the queue into cmss13-devs:master with commit c264e44 Jan 4, 2025
31 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants