.travis.yml: Remove GitHub merge commit workaround #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala-bears.zip[alldeps] --pre -Udocker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala-bears.zip[alldeps] --pre -Udocker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
jayvdb
requested changes
Jul 9, 2018
.travis.yml
Outdated
| @@ -5,25 +5,23 @@ rvm: | |||
| - 2.3.3 | |||
| cache: bundler | |||
|
|
|||
| env: | |||
| global: | |||
| - NOKOGIRI_USE_SYSTEM_LIBRARIES=true # Speeds installation of html-proofer | |||
There was a problem hiding this comment.
This doesnt need to be moved. It is yaml. Order is not important (99% of the time)
There was a problem hiding this comment.
I am sorry I misunderstood. Please tell which core repo are you referring to in your comment above ?
There was a problem hiding this comment.
I made this coala/coala#5617 PR for this reason only.
kriti21
force-pushed
the
removehack
branch
2 times, most recently
from
0221691
to
974cefa
Compare
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala.zip[alldeps] --pre -Upip install coala-bears.zip[alldeps] --pre -Udocker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala.zip[alldeps] --pre -Upip install coala-bears.zip[alldeps] --pre -Udocker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
refeed
reviewed
Jul 9, 2018
There was a problem hiding this comment.
Well, I think the reason why the CI fails is because the coala docker image still uses the old version of coala-bears and coala, which is not the current master.. which doesn't contain your new commit that handles GitHub pull request merge commit.
And docker is containerized, which means that it doesn't read to the outside of the container (the host).
We can either wait until the coala/base docker image is updated, or use the master version of coala and coala-bears to check this repo
The changes here download the latest coala and coala-bears master as zip and use that. It still fails. |
|
@kriti21 The actual check currently is |
|
Ok. So if I make these changes in https://github.com/coala/docker-coala-base first, Will that solve the problem ? @refeed |
|
@kriti21 Yup, it can. But I think we can't release the bears repo now ( coala/coala#5616 (comment) ) @jayvdb |
|
Ugh. This one will need to either
|
|
This .coafile doesnt use many bears. |
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala.zip[alldeps] --pre -Upip install coala-bears.zip[alldeps] --pre -U |
Travis tests have failedHey @kriti21, Ruby: 2.3.3pip install coala.zip[alldeps] --pre -Upip install coala-bears.zip[alldeps] --pre -Ucoala --non-interactive |
Travis tests have failedHey @kriti21, 1st Build.ci/build.sh |
refeed
reviewed
Jul 10, 2018
.travis.yml
Outdated
|
|
||
| matrix: | ||
| include: | ||
| - language: python |
There was a problem hiding this comment.
I think this line overrides the language:ruby which makes the Travis don't run in ruby project mode again.
I have several ideas for this:
- make a separate job for the coala check with
language: python - make this job as
language: pythondirectly, since I think we're currently not using many of therubydevelopment tools
Any idea @jayvdb ?
There was a problem hiding this comment.
https://gitter.im/coala/coala-bears?at=5b44c27a3c5abf52b64b54b8 will solve this problem
There was a problem hiding this comment.
gitmate went nuts on #593 , so we may need to wait a bit.
2 tasks
@sladyn98 Please provide the link to your PR . |
It is right above your comment :P |
Travis tests have failedHey @kriti21, TravisBuddy Request Identifier: 78cde020-5181-11e9-ad12-835a6074a428 |
kriti21
force-pushed
the
removehack
branch
2 times, most recently
from
d120373
to
c76ac2b
Compare
jayvdb
approved these changes
Mar 29, 2019
jayvdb
requested changes
Mar 29, 2019
| <<: *disable_global | ||
| language: python | ||
| python: 3.6 | ||
| cache: pip | ||
| install: pip install moban |
There was a problem hiding this comment.
what ... no ... please keep the moban job, and add an extra coala job.
|
@jayvdb We could also get the coala-bears repo fixed through coala/coala-bears#2897. Can you have a look? :P |
|
Hey @kriti21, TravisCI finished with status TravisBuddy Request Identifier: f71fbe90-5243-11e9-b3ee-317c5c727117 |
jayvdb
reviewed
May 25, 2019
.coafile
Outdated
| @@ -13,6 +13,7 @@ link_ignore_list = | |||
| # clbin.com doesnt work in link_ignore_list | |||
| # See https://github.com/coala/coala-bears/issues/2126 | |||
| link_ignore_regex = clbin.com | |||
| use_spaces = True | |||
There was a problem hiding this comment.
This change does not belong in the " .travis.yml: Remove GitHub merge commit workaround" commit - it is part of the workaround, I guess.
There was a problem hiding this comment.
I've raised bug coala/coala-bears#2949 about this
jayvdb
reviewed
Aug 22, 2019
_projects/add-repo-license.md
Outdated
| @@ -49,7 +49,7 @@ Start by looking through | |||
| sorted by "most stars" or "most forks". | |||
|
|
|||
| Check that GitHub does not show a recognised license at the top of the repository. | |||
| See [Adding a license](https://help.github.com/articles/adding-a-license-to-a-repository/) | |||
| See [Adding a license](https://help.github.com/articles/adding-a-license-to-a-repository) | |||
There was a problem hiding this comment.
im not able to reproduce an error which caused this change, or other removals of trailing /. maybe it was transient.
jayvdb
reviewed
Aug 22, 2019
_reports/GuangyuanYang.md
Outdated
| @@ -164,8 +164,8 @@ investigation/review. Based on this feature, I implemented a | |||
| [script](https://gist.github.com/yzgyyang/13ebb46a5c90ac624b5c6eb43deedc0d) to | |||
| demonstrate the ability of bootstrapping coala Go bears on a bare-metal FreeBSD | |||
| system | |||
| ([Screen record for the demo](https://asciinema.org/a/0poVbHE7lqehV4islFo6cptjb)), | |||
| and it can be expanded to support multiple platforms. | |||
| ([Screen record for the demo]()),and it can be expanded to support multiple | |||
There was a problem hiding this comment.
this is invalid syntax for the link, and ,and is bad grammar.
Also we want this link even though it is broken, as part of the record of this project.
- gitmate.io is permanently down - An asciinema in a report has been removed. - Symlinks cause problems with LineCountBear Closes coala/coala-bears#2950
This was referenced Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!