README.md: Remove Spacing Inconsistency #724

sladyn98 · 2019-03-25T11:27:51Z

Readme.md contained some spacing inconsitency
which has been now removed.

Fixes #713

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

I read the commit guidelines and I've followed
them.
I ran coala over my code locally. (All commits have to pass
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

pick up any PR at https://coala.io/review
review it (check https://coala.io/reviewing for more info)
if you are sure that it needs work, use cobot mark wip <URL> to get it out
of the review queue.

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

TravisBuddy · 2019-03-25T11:31:57Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][11:31:40] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
Executing section html...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...

TravisBuddy Request Identifier: 961d0580-4ef1-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:03:40Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 03551620-4ef6-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:11:12Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 107fcb50-4ef7-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:18:09Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 08778fa0-4ef8-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:38:55Z

Hey @sladyn98,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f1fcae10-4efa-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:45:44Z

Hey @sladyn98,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e60277b0-4efb-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T12:53:52Z

Hey @sladyn98,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 063ca180-4efd-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T13:04:50Z

Hey @sladyn98,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 907865e0-4efe-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T13:11:19Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 76214670-4eff-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T13:28:49Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e7e72e80-4f01-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T13:47:13Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 79e14260-4f04-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T13:54:28Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7edacc90-4f05-11e9-af0a-1da2f5ed2a53

TravisBuddy · 2019-03-25T14:08:07Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 66b787a0-4f07-11e9-af0a-1da2f5ed2a53

.travis.yml

frextrite · 2019-03-27T03:53:01Z

.travis.yml

@@ -22,6 +22,19 @@ jobs:
      cache: pip
      install: pip install moban
      script: .ci/check_moban.sh
+    - stage: coala


and this added?

These changes are not related to the SpaceConsistencyBear issue afaik

No your right these sections are not related. This is related to another issue #600. Actually makman2 and me were planning to fix the CI in this pr itself because gsoc is already upon us. I have discussed this with him and based on that appropriate action will be taken :)

That's great. Just add that issue reference to the comment/pr as well.

frextrite · 2019-03-27T14:34:57Z

.travis.yml

+      python: 3.6
+      cache: pip
+      install:
+        - cOALA_ZIP_URL=https://github.com/coala/coala/archive/master.zip


Suggested change

- cOALA_ZIP_URL=https://github.com/coala/coala/archive/master.zip

- COALA_ZIP_URL=https://codeload.github.com/coala/coala/archive/master.zip

abhishalya · 2019-03-27T17:27:32Z

@sladyn98 I would've really liked if there is a single PR fixing the CI. Two PRs for same purpose makes one redundant. Although this PR references changes regarding space consistency but the goal is same. Anyways, as soon as #600 is finished, you need to cherry pick that commit and push here. We should be able to see the CI green here, since that commit is has been done before than this (following linear git history).

sladyn98 · 2019-03-27T17:30:27Z

@sladyn98 I would've really liked if there is a single PR fixing the CI. Two PRs for same purpose makes one redundant. Although this PR references changes regarding space consistency but the goal is same. Anyways, as soon as #600 is finished, you need to cherry pick that commit and push here. We should be able to see the CI green here, since that commit is has been done before than this (following linear git history).

Yeah @abhishalya your bang on I will remove the changes from my PR once #600 has been fixed :)

abhishalya · 2019-03-27T17:29:42Z

_reports/GuangyuanYang.md

@@ -164,7 +164,7 @@ investigation/review. Based on this feature, I implemented a
 [script](https://gist.github.com/yzgyyang/13ebb46a5c90ac624b5c6eb43deedc0d) to
 demonstrate the ability of bootstrapping coala Go bears on a bare-metal FreeBSD
 system
-([Screen record for the demo](https://asciinema.org/a/0poVbHE7lqehV4islFo6cptjb)),
+([Screen record for the demo]()),


I don't think so this is required. This was reporting InvalidLink because we were using old coala. You should run latest coala and verify if it still throws InvalidLink.

I just followed up on @kriti21's PR and I think she installed the latest coala and still the bear complained.

abhishalya · 2019-03-27T17:30:47Z

_projects/use-coala.md

@@ -64,14 +64,14 @@ so that coala can check most file types.

 Find a GitHub repository that meets all these criteria:

-1. 100 or more [stars](https://help.github.com/articles/about-stars/),
+1. 100 or more [stars](https://help.github.com/articles/about-stars),


Are these changes related to SpaceConsistency?

No the link bear complained even after we installed the latest version so I removed the backslash

Then I think its better to add a new commit for this change. Actually for all invalid link changes.

sladyn98 · 2019-03-27T17:38:15Z

@abhishalya @kriti21 https://travis-ci.org/sladyn98/projects/builds/511483343 I have linked the branch which made the CI green on my local fork you can have a look.The one problem is the asci link. I do not think I should have made that change because we just cannot remove a link from someone's project.So we need to find a workaround that.

TravisBuddy · 2019-03-30T07:27:54Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5088ccf0-52bd-11e9-b3ee-317c5c727117

TravisBuddy · 2019-03-30T07:37:19Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a44a2fe0-52be-11e9-b3ee-317c5c727117

Readme.md contained some spacing inconsitency which has been now removed. Fixes #713

TravisBuddy · 2019-03-30T07:39:52Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][07:39:36] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
Executing section html...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...

TravisBuddy Request Identifier: fc0746f0-52be-11e9-b3ee-317c5c727117

TravisBuddy · 2019-03-30T07:40:57Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][07:40:46] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section spacing...
Executing section html...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...
nothing changed, not updating cache


Done. Your build exited with 1.

TravisBuddy Request Identifier: 260d5570-52bf-11e9-b3ee-317c5c727117

TravisBuddy · 2019-03-30T07:42:32Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][07:42:21] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...

TravisBuddy Request Identifier: 5edb6ae0-52bf-11e9-b3ee-317c5c727117

TravisBuddy · 2019-03-30T07:43:31Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][07:43:14] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
Executing section html...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...

TravisBuddy Request Identifier: 7dfe9be0-52bf-11e9-b3ee-317c5c727117

TravisBuddy · 2019-06-30T19:13:09Z

Travis tests have failed

Hey @sladyn98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Ruby: 2.5.1

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
[ERROR][19:12:55] The bear InvalidLinkBear does not fulfill all requirements. You are not connected to the internet.
Executing section commit...
Executing section linecount...
Executing section filenames...
Executing section markdown_filenames...
Executing section spacing...
Executing section html...
Executing section yml...
Executing section new_linelength_projects...
Executing section old_linelength_projects...
Executing section cli...

TravisBuddy Request Identifier: 150c3bc0-9b6b-11e9-82c9-337585006a18

sladyn98 · 2019-07-30T06:05:18Z

@jayvdb This fixes the spacing inconsistency and is ready to be merged IMO.

KVGarg

Need a correct rebase (2nd commit in ur changes shouldn't be there)!

jayvdb · 2019-08-22T08:05:37Z

Duplicate of #600

gitmate-bot added process/pending review size/XS difficulty/newcomer importance/high labels Mar 25, 2019

frextrite reviewed Mar 27, 2019

View reviewed changes

abhishalya requested changes Mar 27, 2019

View reviewed changes

abhishalya mentioned this pull request Mar 29, 2019

.travis.yml: Remove GitHub merge commit workaround #600

Merged

2 tasks

README.md: Remove Spacing Inconsistency

34b4f47

Readme.md contained some spacing inconsitency which has been now removed. Fixes #713

KVGarg mentioned this pull request Jun 28, 2019

projects.html: Add hyperlink to the mentors' name #721

Merged

2 tasks

Merge branch 'master' into fix_ci

7fe1160

KVGarg suggested changes Aug 13, 2019

View reviewed changes

jayvdb marked this as a duplicate of #600 Aug 22, 2019

jayvdb closed this Aug 22, 2019

	- cOALA_ZIP_URL=https://github.com/coala/coala/archive/master.zip
	- COALA_ZIP_URL=https://codeload.github.com/coala/coala/archive/master.zip

README.md: Remove Spacing Inconsistency #724

README.md: Remove Spacing Inconsistency #724

Conversation

sladyn98 commented Mar 25, 2019

Checklist

TravisBuddy commented Mar 25, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: 961d0580-4ef1-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 03551620-4ef6-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 107fcb50-4ef7-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 08778fa0-4ef8-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

TravisBuddy Request Identifier: f1fcae10-4efa-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

TravisBuddy Request Identifier: e60277b0-4efb-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

TravisBuddy Request Identifier: 063ca180-4efd-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

TravisBuddy Request Identifier: 907865e0-4efe-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 76214670-4eff-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: e7e72e80-4f01-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 79e14260-4f04-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 7edacc90-4f05-11e9-af0a-1da2f5ed2a53

TravisBuddy commented Mar 25, 2019

Travis tests have failed

TravisBuddy Request Identifier: 66b787a0-4f07-11e9-af0a-1da2f5ed2a53

frextrite Mar 27, 2019

Choose a reason for hiding this comment

sladyn98 Mar 27, 2019

Choose a reason for hiding this comment

frextrite Mar 27, 2019

Choose a reason for hiding this comment

frextrite Mar 27, 2019

Choose a reason for hiding this comment

abhishalya commented Mar 27, 2019

sladyn98 commented Mar 27, 2019

abhishalya Mar 27, 2019

Choose a reason for hiding this comment

sladyn98 Mar 27, 2019

Choose a reason for hiding this comment

abhishalya Mar 27, 2019

Choose a reason for hiding this comment

sladyn98 Mar 27, 2019 • edited Loading

Choose a reason for hiding this comment

abhishalya Mar 27, 2019 • edited Loading

Choose a reason for hiding this comment

sladyn98 commented Mar 27, 2019

TravisBuddy commented Mar 30, 2019

Travis tests have failed

TravisBuddy Request Identifier: 5088ccf0-52bd-11e9-b3ee-317c5c727117

TravisBuddy commented Mar 30, 2019

Travis tests have failed

TravisBuddy Request Identifier: a44a2fe0-52be-11e9-b3ee-317c5c727117

TravisBuddy commented Mar 30, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: fc0746f0-52be-11e9-b3ee-317c5c727117

TravisBuddy commented Mar 30, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: 260d5570-52bf-11e9-b3ee-317c5c727117

TravisBuddy commented Mar 30, 2019

Travis tests have failed

Ruby: 2.5.1

TravisBuddy Request Identifier: 5edb6ae0-52bf-11e9-b3ee-317c5c727117

sladyn98 Mar 27, 2019 •

edited

Loading

abhishalya Mar 27, 2019 •

edited

Loading

KVGarg left a comment •

edited

Loading