Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Filter::run() - Changed the way after method runs #6262

Closed
wants to merge 3 commits into from
Closed

Refactoring Filter::run() - Changed the way after method runs #6262

wants to merge 3 commits into from

Commits on Jul 13, 2022

  1. Reversing Filter::after execution 

    With current functionality, execution of multi filters are sequential. First it runs all the before and later afters.
Consider this scenario, If we are walking through 2 doors, we go through door 1 and then door 2 and If we want to walk back, we come through door 2 first and then door 1 and this completely make sense. Similarly, with multiple filters. The last executed before should execute it's after first.
    @vedavith
    vedavith authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    9860dbc View commit details
    Browse the repository at this point in the history

  2. Updated Comments

    @vedavith
    vedavith authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b2e691f View commit details
    Browse the repository at this point in the history

  3. Fixing PSR issue

    @vedavith
    vedavith authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a680c48 View commit details
    Browse the repository at this point in the history