Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Filter::run() - Changed the way after method runs #6262

Closed
wants to merge 3 commits into from
Closed

Refactoring Filter::run() - Changed the way after method runs #6262

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9860dbc
Reversing Filter::after execution
vedavith Jul 13, 2022
b2e691f
Updated Comments
vedavith Jul 13, 2022
a680c48
Fixing PSR issue
vedavith Jul 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion system/Filters/Filters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ public function setResponse(ResponseInterface $response)
public function run(string $uri, string $position = 'before')
{
$this->initialize(strtolower($uri));
// reversing after filters
if ($position === 'after') {
$this->filtersClass[$position] = array_reverse($this->filtersClass[$position]);
}

foreach ($this->filtersClass[$position] as $className) {
$class = new $className();
Expand Down Expand Up @@ -230,7 +234,6 @@ public function initialize(?string $uri = null)
$this->processGlobals($uri);
$this->processMethods();
$this->processFilters($uri);

// Set the toolbar filter to the last position to be executed
if (in_array('toolbar', $this->filters['after'], true)
&& ($count = count($this->filters['after'])) > 1
Expand Down