Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InSeong-So
approved these changes
Dec 17, 2023
Comment on lines
+27
to
+54
| const handleOpenPopover = useCallback((e: MouseEvent) => { | ||
| e.preventDefault(); | ||
| setPopoverIsOpen(!popoverIsOpen); | ||
| }, []); | ||
|
|
||
| const handleClosePopover = useCallback(() => { | ||
| setPopoverIsOpen(false); | ||
| }, []); | ||
|
|
||
| const handleOpenModalDeleteLink = useCallback((e: MouseEvent) => { | ||
| e.preventDefault(); | ||
| setModalDeleteLinkIsOpen(true); | ||
| }, []); | ||
|
|
||
| const handleCloseModalDeleteLink = useCallback((e: MouseEvent) => { | ||
| e.preventDefault(); | ||
| setModalDeleteLinkIsOpen(false); | ||
| }, []); | ||
|
|
||
| const handleOpenModalAddLink = useCallback((e: MouseEvent) => { | ||
| e.preventDefault(); | ||
| setModalAddLinkIsOpen(true); | ||
| }, []); | ||
|
|
||
| const handleCloseModalAddLink = useCallback((e: MouseEvent) => { | ||
| e.preventDefault(); | ||
| setModalAddLinkIsOpen(false); | ||
| }, []); |
There was a problem hiding this comment.
커스텀 훅으로 분리하면 좀 더 UI에 집중할 수 있는 컴포넌트가 될 것 같네요!
Comment on lines
+36
to
+38
| const onSubmit = (data: IFormInput) => { | ||
| submitForm(data); | ||
| }; |
Comment on lines
+45
to
+49
| const response1 = await apiRequest({ url: '/sample/folder' }); | ||
| const folder = response1.data?.folder; | ||
|
|
||
| const response2 = await apiRequest({ url: '/sample/user' }); | ||
| const profile = response2.data; |
There was a problem hiding this comment.
response1의 통신이 종료될 때까지 response2는 대기될 텐데, 그럼 네트워크 통신에 병목이 생길 수 있습니다. 이를 해결하려면 어떻게 하는 것이 좋을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
Input컴포넌트와 로그인, 회원가입 페이지 구현Nav컴포넌트가 페이지 컴포넌트에서 페칭한 데이터를 prop으로 받아서 렌더링하도록 리팩토링스크린샷
멘토에게
Input컴포넌트와 로그인, 회원가입 페이지에서 개선해야할 부분이 있는지 궁금합니다.