-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[안성재] Week14 #517
Merged
InSeong-So
merged 16 commits into
codeit-bootcamp-frontend:part3-안성재
from
asusia1111:part3-안성재-week14
Dec 17, 2023
The head ref may contain hidden characters: "part3-\uC548\uC131\uC7AC-week14"
Merged
[안성재] Week14 #517
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f3d10f6
chore: fetch 함수 네이밍 수정
asusia1111 5d032c1
chore: IntersectionObserver 내부 조건문 간결화
asusia1111 620e69d
refactor: 이벤트 핸들러 인라인 함수 최대한 사용하지 않도록 수정
asusia1111 0308a1d
refactor: 카드 리스트 컴포넌트 early return 사용하도록 수정
asusia1111 920bb6f
refactor: 옵셔널 체이닝 사용하지 않도록 수정
asusia1111 641895f
feat: 로그인, 회원가입 페이지 1차 구현
asusia1111 8630817
chore: react-hook-form 설치
asusia1111 91a1187
feat: 로그인 페이지 react-hook-form을 사용해서 구현
asusia1111 3a06e3d
feat: 회원가입 페이지 react-hook-form을 사용해서 구현, accessToken을 저장하고 사용하도록 기능 추가
asusia1111 df87075
feat: 비밀번호와 비밀번호 확인의 일치 여부를 입력값이 변할 때마다 확인하도록 추가
asusia1111 c675d97
feat: 정규식 상수 utils 디렉토리의 regex 파일로 분리
asusia1111 c8358cc
refactor: 함수 컴포넌트 화살표 함수 방식으로 변경
asusia1111 211f507
feat: HTML로 작성된 기존 랜딩 페이지 마이그레이션
asusia1111 189c495
feat: Nav 컴포넌트에서 데이터 페칭하지 않고 페이지 컴포넌트에서 prop으로 받도록 로직 수정
asusia1111 0cf3299
refactor: JSX 코드에서 && 연산자 삼항 연산자로 수정
asusia1111 c66ecff
chore: API 주소 환경 변수로 설정
asusia1111 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -36,7 +36,4 @@ yarn-error.log* | |
next-env.d.ts | ||
|
||
# spell | ||
cspell.json | ||
|
||
# signin | ||
src/pages/signin.tsx | ||
cspell.json |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
import axios, { AxiosRequestConfig } from 'axios'; | ||
|
||
const api = axios.create({ | ||
baseURL: 'https://bootcamp-api.codeit.kr/api/', | ||
baseURL: process.env.NEXT_PUBLIC_BASE_URL, | ||
}); | ||
|
||
const fetch = async (options: AxiosRequestConfig) => { | ||
const apiRequest = async (options: AxiosRequestConfig) => { | ||
const response = await api({ ...options }); | ||
return response; | ||
}; | ||
|
||
export default fetch; | ||
export default apiRequest; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
커스텀 훅으로 분리하면 좀 더 UI에 집중할 수 있는 컴포넌트가 될 것 같네요!