Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmin20
reviewed
Apr 29, 2024
| <h1 class="header-logo"> | ||
| <a href="/" | ||
| ><img | ||
| src="images/logo.png" |
There was a problem hiding this comment.
보니까 2배, 3배로 추출한 이미지를 따로 사용하지 않는 것 같은데, 파일을 추가하신 이유가 있으실까요?
danmin20
reviewed
Apr 29, 2024
Comment on lines
+121
to
+122
| <a href="https://www.facebook.com/" target="_blank" rel="noopener" | ||
| ><img |
There was a problem hiding this comment.
들여쓰기가 전체적으로 이상한 것 같아요~
a태그와 img태그에 대해서 이상하게 작성된 것 같네요.
danmin20
reviewed
Apr 29, 2024
| height="51" | ||
| /></a> | ||
| </h1> | ||
| <a href="pages/login.html">로그인</a> |
There was a problem hiding this comment.
a 태그는 보통 anchor나 다른 외부 하이퍼링크에 사용되어요. 커스텀한 스타일의 버튼은 button 태그를 사용하는 게 더 좋아보입니다~
danmin20
reviewed
Apr 29, 2024
Comment on lines
+21
to
+32
| header > a { | ||
| display: block; | ||
| width: 128px; | ||
| height: 48px; | ||
| padding: 12px 20px; | ||
| border-radius: 8px; | ||
| color: #fff; | ||
| background-color: #3692FF; | ||
| font-weight: 600; | ||
| text-align: center; | ||
| white-space: nowrap; | ||
| } |
There was a problem hiding this comment.
보니까 button에 대한 스타일링인 것 같은데,
피그마로 보면 btn_large, btn_small 로 정의되어 있어요. 디자인 시스템과 명칭을 일치시키는 것도 좋은 방법이에요~
그리고 hover, active 에 대한 css도 추가하면 좋을 것 같아요.
danmin20
reviewed
Apr 29, 2024
| color: #374151; | ||
| } | ||
|
|
||
| header { |
There was a problem hiding this comment.
보통 header는 fixed 되는 게 일반적이기는 합니다!
danmin20
reviewed
Apr 29, 2024
|
|
||
| .section1 > .bg-img { | ||
| position: absolute; | ||
| top: 93px; left: 36.51vw; |
danmin20
reviewed
Apr 29, 2024
|
|
||
| .section1 > .container a { | ||
| padding: 16px 124px; | ||
| border-radius: 40px;; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게