Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[김당찬] Sprint1 #35

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
142 changes: 142 additions & 0 deletions css/main.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
* {
box-sizing: border-box;
padding: 0;
margin: 0;
text-decoration: none;
color: #374151;
}

header {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보통 header는 fixed 되는 게 일반적이기는 합니다!

display: flex;
justify-content: space-between;
align-items: center;
width: 100%;
padding: 10px 200px;
}

header > h1 {
height: 51px;
}

header > a {
display: block;
width: 128px;
height: 48px;
padding: 12px 20px;
border-radius: 8px;
color: #fff;
background-color: #3692FF;
font-weight: 600;
text-align: center;
white-space: nowrap;
}
Comment on lines +21 to +32
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보니까 button에 대한 스타일링인 것 같은데,
피그마로 보면 btn_large, btn_small 로 정의되어 있어요. 디자인 시스템과 명칭을 일치시키는 것도 좋은 방법이에요~
그리고 hover, active 에 대한 css도 추가하면 좋을 것 같아요.


.container {
max-width: 1200px;
width: 100%;
margin: 0 auto;
}

h2 {
font-size: 40px;
font-weight: 700;
}

.section1, .section3 {
position: relative;
height: 540px;
background-color: #CFE5FF;
}

.section1 > .bg-img {
position: absolute;
top: 93px; left: 36.51vw;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엔터가 빠져있네요!

z-index: 0;
}

.section1 > .container, .section3 > .container {
display: flex;
flex-direction: column;
justify-content: center;
align-items: start;
gap: 32px;
position: relative;
z-index: 1;
height: 100%;
}

.section1 > .container a {
padding: 16px 124px;
border-radius: 40px;;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세미콜론이 하나 더 들어가있어요~

background-color: #3692FF;
color: #fff;
font-size: 20px;
font-weight: 600;
}

.section2 .container {
display: flex;
align-items: center;
gap: 64px;
padding: 138px 0;
}

.section2 .container.right {
flex-direction: row-reverse;
text-align: right;
}

.section2 .container .subtitle {
margin-bottom: 12px;
color: #3692FF;
font-size: 18px;
font-weight: 700;
}

.section2 .container .description {
margin-top: 24px;
font-size: 24px;
font-weight: 500;
}

.section3 > .bg-img {
position: absolute;
top: 0; left: 36.51vw;
z-index: 0;
}

footer {
display: flex;
justify-content: space-between;
align-items: start;
width: 100%;
height: 160px;
padding: 32px 200px;
background-color: #111827;
font-size: 16px;
font-weight: 400;
white-space: nowrap;
}

footer > div:first-child {
flex-basis: 200px;
color: #9CA3AF;
}

footer > .fnav a {
color: #9CA3AF;
margin-right: 30px;
}

footer > .sns {
flex-basis: 200px;
text-align: right;
}

footer > .sns a {
margin-right: 12px;
}

footer > .fnav a:last-child, footer > .sns a:last-child {
margin-right: 0;
}
Binary file added images/Img_home_01.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_02.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_03.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_bottom.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/Img_home_top.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_facebook.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_twitter.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/ic_youtube.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/logo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
152 changes: 152 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,152 @@
<!DOCTYPE html>
<html lang="ko">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>판다월드</title>
<link rel="stylesheet" href="css/main.css" />
</head>
<body>
<header>
<h1 class="header-logo">
<a href="/"
><img
src="images/logo.png"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

보니까 2배, 3배로 추출한 이미지를 따로 사용하지 않는 것 같은데, 파일을 추가하신 이유가 있으실까요?

alt="판다마켓로고"
width="153"
height="51"
/></a>
</h1>
<a href="pages/login.html">로그인</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a 태그는 보통 anchor나 다른 외부 하이퍼링크에 사용되어요. 커스텀한 스타일의 버튼은 button 태그를 사용하는 게 더 좋아보입니다~

</header>
<main>
<section class="section1">
<img
class="bg-img"
src="images/Img_home_top.png"
alt="판다이미지"
width="996"
height="447"
/>
<div class="container">
<h2>
일상의 모든 물건을<br />
거래해 보세요
</h2>
<a href="pages/items.html">구경하러 가기</a>
</div>
</section>
<section class="section2">
<div class="container">
<img
src="images/Img_home_01.png"
alt="인기상품이미지"
width="588"
height="444"
/>
<div>
<div class="subtitle">Hot Item</div>
<h2 class="title">
인기 상품을<br />
확인해 보세요
</h2>
<p class="description">
가장 HOT한 중고거래 물품을<br />
판다 마켓에서 확인해 보세요
</p>
</div>
</div>
<div class="container right">
<img
src="images/Img_home_02.png"
alt="검색이미지"
width="588"
height="444"
/>
<div>
<div class="subtitle">search</div>
<h2 class="title">
구매를 원하는<br />
상품을 검색하세요
</h2>
<p class="description">
구매하고 싶은 물품은 검색해서<br />
쉽게 찾아보세요
</p>
</div>
</div>
<div class="container">
<img
src="images/Img_home_03.png"
alt="상품등록이미지"
width="588"
height="444"
/>
<div>
<div class="subtitle">Register</div>
<h2 class="title">
판매를 원하는<br />
상품을 등록하세요
</h2>
<p class="description">
어떤 물건이든 판매하고 싶은 상품을<br />
쉽게 등록하세요
</p>
</div>
</div>
</section>
<section class="section3">
<img
class="bg-img"
src="images/Img_home_bottom.png"
alt="판다대화이미지"
width="996"
height="540"
/>
<div class="container">
<h2>
믿을 수 있는<br />
판다마켓 중고거래
</h2>
</div>
</section>
</main>
<footer>
<div>©codeit - 2024</div>
<div class="fnav">
<a href="pages/privacy.html">Privacy Policy</a>
<a href="pages/faq.html">FAQ</a>
</div>
<div class="sns">
<a href="https://www.facebook.com/" target="_blank" rel="noopener"
><img
Comment on lines +121 to +122
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

들여쓰기가 전체적으로 이상한 것 같아요~
a태그와 img태그에 대해서 이상하게 작성된 것 같네요.

src="images/ic_facebook.png"
alt="페이스북 아이콘"
width="20"
height="20"
/></a>
<a href="https://twitter.com/" target="_blank" rel="noopener"
><img
src="images/ic_twitter.png"
alt="트위터 아이콘"
width="20"
height="20"
/></a>
<a href="https://www.youtube.com/" target="_blank" rel="noopener"
><img
src="images/ic_youtube.png"
alt="유튜브 아이콘"
width="20"
height="20"
/></a>
<a href="https://www.instagram.com/" target="_blank" rel="noopener"
><img
src="images/ic_instagram.png"
alt="인스타그램 아이콘"
width="20"
height="20"
/></a>
</div>
</footer>
</body>
</html>
11 changes: 11 additions & 0 deletions pages/faq.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
faq
</body>
</html>
11 changes: 11 additions & 0 deletions pages/items.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
items
</body>
</html>
11 changes: 11 additions & 0 deletions pages/login.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
login
</body>
</html>
11 changes: 11 additions & 0 deletions pages/privacy.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>Document</title>
</head>
<body>
privacy
</body>
</html>
Loading