Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop codecov-action@v3, enable codecov by default #32

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Jun 27, 2024

Two reasons to do this:

  1. We should really be tracking our coverage better in colcon. Some of the critical path repos have zero tests.
  2. Relying on the CODECOV_TOKEN secret being non-empty means that PRs from forks don't get coverage uploads, so comparing with '' was never the correct thing to do anyway.

Repositories can still opt out of coverage, but because we're going to want this on nearly all of the repositories anyway, we should just make it the default.

@cottsay cottsay requested a review from nuclearsandwich June 27, 2024 22:17
@cottsay cottsay self-assigned this Jun 27, 2024
@cottsay cottsay merged commit d0949f7 into main Jun 28, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/codecov-everywhere branch June 28, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants