Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to specify strategy #38

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

taughz
Copy link

@taughz taughz commented Dec 19, 2024

Adds new arguments the pytest.yaml reusable workflow, to make it easier to specify a strategy. To generate the strategy, a small utility genstrat.py has been added. By default, this utility will output a file identical to the old strategy.json (which has been deleted). It is still possible to use matrix-filter, if a user prefers to use that.

Resolves: #37

Adds new arguments the `pytest.yaml` reusable workflow, to make it
easier to specify a strategy. To generate the strategy, a small utility
`genstrat.py` has been added. By default, this utility will output a
file identical to the old `strategy.json` (which has been deleted). It
is still possible to use `matrix-filter`, if a user prefers to use that.

Resolves: colcon#37
@taughz
Copy link
Author

taughz commented Jan 27, 2025

Can someone please look at this PR?

@taughz
Copy link
Author

taughz commented Feb 16, 2025

So I know there was a response to #37, but I wonder if you might still consider merging this PR? It doesn't add too much code, it is backwards compatible. This is just my opinion, but I think it's easier to understand than the jq filter. I am using this fork for my own Colcon extension, which I will be making public soon, hopefully.

@taughz
Copy link
Author

taughz commented Feb 19, 2025

Here's my Colcon extension, and the workflow using the updated action: https://github.com/taughz/colcon-package-of/blob/98cc23b70348a2b171cf6f48415dacb934047032/.github/workflows/ci.yaml#L16

jobs:
  pytest:
    uses: taughz/colcon-ci/.github/workflows/pytest.yaml@main
    with:
      strategy-os: |
        macos-latest
        ubuntu-22.04
      strategy-python: |
        3.10
        3.11
        3.12
      strategy-include-py36: false
      strategy-include-stdeb: false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Provide some examples of using matrix-filter
2 participants