Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eudev: Add recipe #20335

Merged
merged 14 commits into from
Mar 14, 2024
Merged

eudev: Add recipe #20335

merged 14 commits into from
Mar 14, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Oct 3, 2023

Specify library name and version: eudev/3.2.12

eudev is an alternative implementation of systemd's libudev library.
This package indicates this with provides = "libudev".
A libblkid Conan package is missing, but should be added and default enabled in this package. Here's an attempt at that: #22426


@conan-center-bot

This comment has been minimized.

@jwillikers jwillikers mentioned this pull request Oct 4, 2023
6 tasks
@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

@RubenRBS Would you have any insight into this CI failure?

@AbrilRBS
Copy link
Member

Rebuilding those missing binaries now, thanks for the ping :)

@AbrilRBS AbrilRBS self-assigned this Oct 11, 2023
@AbrilRBS
Copy link
Member

We're going to implement a mechanism for PR's to be automatically retriggered when its corresponding builds are completed, sorry about the delay! :)

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Just started an internal build to generate kmod.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

I've enabled blkid now that it's a separate component!

Set the version for pkg-config properly and set exec_prefix.
This maps to version checks for libudev.
@conan-center-bot conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Mar 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Mar 5, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

Alright, @RubenRBS I think this is ready now, but just needs that missing kmod binary for v2.

@jwillikers jwillikers requested a review from valgur March 5, 2024 15:38
@AbrilRBS
Copy link
Member

AbrilRBS commented Mar 5, 2024

This comes from kmod being a shared-library, but it requires opencv as static, and thus when this recipe is built as shared (Where we pass *:shared=True), it gets opencv as a missing dependency - Will check with the team about how to best handle these cases tomorrow, will let you know

@conan-center-bot

This comment has been minimized.

@jwillikers
Copy link
Contributor Author

jwillikers commented Mar 12, 2024

This comes from kmod being a shared-library, but it requires opencv as static, and thus when this recipe is built as shared (Where we pass *:shared=True), it gets opencv as a missing dependency - Will check with the team about how to best handle these cases tomorrow, will let you know

@RubenRBS Any developments?

@uilianries
Copy link
Member

hello @jwillikers Sorry the delay, we have a hotfix prepared and tested. We update the infra on Wednesdays #20497, so it should be fixed by tomorrow, after the maintenance window.

@jwillikers
Copy link
Contributor Author

hello @jwillikers Sorry the delay, we have a hotfix prepared and tested. We update the infra on Wednesdays #20497, so it should be fixed by tomorrow, after the maintenance window.

@uilianries Awesome, thank you!

@conan-center-bot conan-center-bot added Service Under Maintenance and removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Mar 13, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (d444f29d321df7291b3bf11d1db7d2b96b8c30c4):

  • eudev/3.2.14:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (d444f29d321df7291b3bf11d1db7d2b96b8c30c4):

  • eudev/3.2.14:
    All packages built successfully! (All logs)

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay

@jwillikers jwillikers requested a review from valgur March 13, 2024 18:56
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit cab4970 into conan-io:master Mar 14, 2024
13 checks passed
@jwillikers jwillikers deleted the eudev branch March 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants