Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmount: Make the libblkid and libmount libraries separate components #22426

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jwillikers
Copy link
Contributor

@jwillikers jwillikers commented Jan 18, 2024

Adding the eudev package, #20335, requires libblkid only. Adding a separate libblkid recipe, PR #20373, hasn't gotten anywhere yet. This PR uses an alternative approach and separates the libraries. Each library is split into its own component.


Adding the eudev package requires `libblkid` only.
Adding a separate libblkid recipe hasn't gotten anywhere yet.
This PR uses an alternative approach and separates the libraries.
Each library is split into its own component.
@ghost
Copy link

ghost commented Jan 18, 2024

I detected other pull requests that are modifying libmount/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (2b236c12493aebcef19b972a1ab21261053fade8):

  • libmount/2.39.2:
    All packages built successfully! (All logs)

  • libmount/2.39:
    All packages built successfully! (All logs)

  • libmount/2.36:
    All packages built successfully! (All logs)

  • libmount/2.36.2:
    All packages built successfully! (All logs)

  • libmount/2.33.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (2b236c12493aebcef19b972a1ab21261053fade8):

  • libmount/2.36:
    All packages built successfully! (All logs)

  • libmount/2.39.2:
    All packages built successfully! (All logs)

  • libmount/2.39:
    All packages built successfully! (All logs)

  • libmount/2.36.2:
    All packages built successfully! (All logs)

  • libmount/2.33.1:
    All packages built successfully! (All logs)

@jwillikers jwillikers mentioned this pull request Feb 29, 2024
3 tasks
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this one, thanks a lot for splitting it - will close the other PR once this gets merged :)

@AbrilRBS AbrilRBS self-assigned this Mar 4, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missclick

@conan-center-bot conan-center-bot merged commit 4f9bc01 into conan-io:master Mar 5, 2024
34 checks passed
@jwillikers jwillikers deleted the libmount-add-libblkid branch March 5, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants