Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sundials: add v7.1.1, v6.7.0, v5.8.0, add optional deps, fix CMake names #21664

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Dec 6, 2023

Adds the latest major versions.

Also:

  • Adds all optional dependencies that are available on CCI or in a pending PR.
  • Updates the CMake config file name to SUNDIALS and CMake component names to SUNDIALS::<component> to match the project.
  • Dropped the sundials_ prefix from the Conan components to match the CMake component names.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

Copy link
Contributor

Hooks produced the following warnings for commit 220151f
sundials/5.8.0@#2eadd34fe8222e09de2bc460a5edb8aa
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libsundials_sunnonlinsolfixedpoint.2.8.0.dylib, libsundials_nvecserial.5.dylib, libsundials_sunlinsolspfgmr.3.8.0.dylib, libsundials_nvecmanyvector.5.dylib, libsundials_sunnonlinsolnewton.dylib, libsundials_cvode.5.8.0.dylib, libsundials_sunmatrixsparse.dylib, libsundials_ida.dylib, libsundials_generic.dylib, libsundials_cvodes.dylib, libsundials_idas.4.8.0.dylib, libsundials_nvecmanyvector.dylib, libsundials_sunmatrixband.3.8.0.dylib, libsundials_sunlinsolband.dylib, libsundials_sunlinsolsptfqmr.dylib, libsundials_cvodes.5.8.0.dylib, libsundials_nvecserial.5.8.0.dylib, libsundials_nvecserial.dylib, libsundials_sunlinsolpcg.dylib, libsundials_idas.4.dylib, libsundials_sunmatrixband.3.dylib, libsundials_arkode.4.dylib, libsundials_sunlinsolspgmr.3.8.0.dylib, libsundials_arkode.dylib, libsundials_generic.5.8.0.dylib, libsundials_sunlinsolpcg.3.8.0.dylib, libsundials_sunlinsolspbcgs.dylib, libsundials_sunlinsolspgmr.dylib, libsundials_cvode.dylib, libsundials_sunlinsolspfgmr.dylib, libsundials_kinsol.5.dylib, libsundials_kinsol.dylib, libsundials_sunmatrixsparse.3.8.0.dylib, libsundials_sunlinsoldense.dylib, libsundials_ida.5.dylib, libsundials_sunmatrixband.dylib, libsundials_sunmatrixdense.3.8.0.dylib, libsundials_sunmatrixdense.3.dylib, libsundials_sunnonlinsolnewton.2.8.0.dylib, libsundials_sunlinsoldense.3.8.0.dylib, libsundials_sunnonlinsolfixedpoint.dylib, libsundials_cvode.5.dylib, libsundials_cvodes.5.dylib, libsundials_sunmatrixsparse.3.dylib, libsundials_sunmatrixdense.dylib, libsundials_sunlinsolspbcgs.3.8.0.dylib, libsundials_nvecmanyvector.5.8.0.dylib, libsundials_generic.5.dylib, libsundials_sunlinsolsptfqmr.3.8.0.dylib, libsundials_sunlinsolband.3.8.0.dylib, libsundials_idas.dylib, libsundials_ida.5.8.0.dylib, libsundials_kinsol.5.8.0.dylib, libsundials_arkode.4.8.0.dylib
sundials/6.7.0@#5230a6c4de9e76e77695769e41b15132
post_package(): WARN: [APPLE RELOCATABLE SHARED LIBS (KB-H077)] install_name dir of these shared libs is not @rpath: libsundials_sunnonlinsolnewton.3.dylib, libsundials_arkode.5.dylib, libsundials_sunlinsolband.4.7.0.dylib, libsundials_arkode.5.7.0.dylib, libsundials_sunmatrixdense.4.dylib, libsundials_sunnonlinsolnewton.dylib, libsundials_sunmatrixsparse.dylib, libsundials_idas.5.dylib, libsundials_sunlinsolpcg.4.dylib, libsundials_ida.dylib, libsundials_sunmatrixband.4.dylib, libsundials_generic.dylib, libsundials_cvodes.dylib, libsundials_generic.6.7.0.dylib, libsundials_sunlinsolspfgmr.4.dylib, libsundials_nvecmanyvector.dylib, libsundials_cvodes.6.7.0.dylib, libsundials_sunlinsolsptfqmr.4.dylib, libsundials_kinsol.6.dylib, libsundials_sunlinsolspbcgs.4.dylib, libsundials_sunlinsolband.dylib, libsundials_nvecserial.6.7.0.dylib, libsundials_ida.6.dylib, libsundials_sunlinsolsptfqmr.dylib, libsundials_nvecmanyvector.6.dylib, libsundials_sunlinsolspbcgs.4.7.0.dylib, libsundials_nvecserial.dylib, libsundials_nvecserial.6.dylib, libsundials_sunlinsolpcg.dylib, libsundials_sunlinsoldense.4.dylib, libsundials_sunlinsoldense.4.7.0.dylib, libsundials_arkode.dylib, libsundials_sunlinsolspbcgs.dylib, libsundials_sunlinsolsptfqmr.4.7.0.dylib, libsundials_sunlinsolspgmr.dylib, libsundials_cvode.dylib, libsundials_cvode.6.7.0.dylib, libsundials_sunlinsolspfgmr.dylib, libsundials_kinsol.dylib, libsundials_sunlinsoldense.dylib, libsundials_sunmatrixband.dylib, libsundials_sunnonlinsolnewton.3.7.0.dylib, libsundials_sunnonlinsolfixedpoint.dylib, libsundials_sunlinsolband.4.dylib, libsundials_sunlinsolspgmr.4.7.0.dylib, libsundials_ida.6.7.0.dylib, libsundials_kinsol.6.7.0.dylib, libsundials_sunmatrixdense.dylib, libsundials_sunmatrixsparse.4.7.0.dylib, libsundials_sunnonlinsolfixedpoint.3.dylib, libsundials_sunmatrixdense.4.7.0.dylib, libsundials_sunlinsolpcg.4.7.0.dylib, libsundials_cvode.6.dylib, libsundials_idas.5.7.0.dylib, libsundials_idas.dylib, libsundials_sunlinsolspgmr.4.dylib, libsundials_cvodes.6.dylib, libsundials_sunlinsolspfgmr.4.7.0.dylib, libsundials_nvecmanyvector.6.7.0.dylib, libsundials_sunmatrixband.4.7.0.dylib, libsundials_sunmatrixsparse.4.dylib, libsundials_generic.6.dylib, libsundials_sunnonlinsolfixedpoint.3.7.0.dylib

@AbrilRBS AbrilRBS self-assigned this Jan 6, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @valgu! Can you take a look at the hook warnings before merging? Thanks!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur valgur changed the title sundials: add v7.1.1, v6.7.0, v5.8.0 sundials: add v7.1.1, v6.7.0, v5.8.0, add optional deps, fix CMake names Sep 11, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 10 (8aea036e3bc08a3a0aba2ee4faf965318c0a835b):

  • sundials/6.7.0:
    CI failed to create some packages (All logs)

    Logs for packageID a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    [options]
    sundials:shared=False
    
    [...]
    Run Build Command(s):/usr/bin/make && /usr/bin/cmake -S/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest -B/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest --check-build-system CMakeFiles/Makefile.cmake 0
    /usr/bin/cmake -E cmake_progress_start /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest/CMakeFiles /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest//CMakeFiles/progress.marks
    /usr/bin/make  -f CMakeFiles/Makefile2 all
    make[1]: Entering directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    /usr/bin/make  -f CMakeFiles/ltest.dir/build.make CMakeFiles/ltest.dir/depend
    make[2]: Entering directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    cd /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest/CMakeFiles/ltest.dir/DependInfo.cmake
    Scanning dependencies of target ltest
    make[2]: Leaving directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    /usr/bin/make  -f CMakeFiles/ltest.dir/build.make CMakeFiles/ltest.dir/build
    make[2]: Entering directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    [ 50%] Building C object CMakeFiles/ltest.dir/ltest.c.o
    /usr/bin/gcc   -m64 -O3 -DNDEBUG -fPIE -std=gnu99 -o CMakeFiles/ltest.dir/ltest.c.o -c /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest/ltest.c
    [100%] Linking C executable ltest
    /usr/bin/cmake -E cmake_link_script CMakeFiles/ltest.dir/link.txt --verbose=1
    /usr/bin/gcc -m64 -O3 -DNDEBUG -m64 CMakeFiles/ltest.dir/ltest.c.o -o ltest  /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/openblas/0.3.27/_/_/package/3d6f0bf98dc75c8f35acf9f3ac91400c2f41c0d9/lib/libopenblas.a /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/openblas/0.3.27/_/_/package/3d6f0bf98dc75c8f35acf9f3ac91400c2f41c0d9/lib/libopenblas.a -lpthread 
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/openblas/0.3.27/_/_/package/3d6f0bf98dc75c8f35acf9f3ac91400c2f41c0d9/lib/libopenblas.a(dgetrf_parallel.c.o): in function `dgetrf_parallel.localalias':
    dgetrf_parallel.c:(.text+0x185e): undefined reference to `sqrt'
    /usr/bin/ld: dgetrf_parallel.c:(.text+0x18a5): undefined reference to `sqrt'
    collect2: error: ld returned 1 exit status
    make[2]: *** [CMakeFiles/ltest.dir/build.make:108: ltest] Error 1
    make[2]: Leaving directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    make[1]: *** [CMakeFiles/Makefile2:98: CMakeFiles/ltest.dir/all] Error 2
    make[1]: Leaving directory '/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/LapackTest'
    make: *** [Makefile:106: all] Error 2
    
    
    CMake Error at cmake/macros/SundialsCMakeMacros.cmake:89 (message):
      ************************************************************************
    
      ERROR: SUNDIALS interface to LAPACK is not functional.
    
      ************************************************************************
    Call Stack (most recent call first):
      cmake/tpl/SundialsLapack.cmake:132 (print_error)
      cmake/SundialsSetupTPLs.cmake:122 (include)
      CMakeLists.txt:171 (include)
    
    
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    sundials/6.7.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    sundials/6.7.0: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    sundials/6.7.0: ERROR: Package 'a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f' build failed
    sundials/6.7.0: WARN: Build folder /home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release
    ERROR: sundials/6.7.0: Error in build() method, line 224
    	cmake.configure()
    	ConanException: Error 1 while executing cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/build/Release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/package/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f" -DCMAKE_TRY_COMPILE_CONFIGURATION="Release" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/home/conan/workspace/prod-v1/bsr/96342/eacef/.conan/data/sundials/6.7.0/_/_/build/a540cc10d8ac89bf8a5cd5ffc7cd431f4d0a0f2f/src"
    
  • sundials/5.4.0:
    Didn't run or was cancelled before finishing

  • sundials/7.1.1:
    Didn't run or was cancelled before finishing

  • sundials/5.3.0:
    Didn't run or was cancelled before finishing

  • sundials/5.8.0:
    Didn't run or was cancelled before finishing

  • sundials/5.2.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 10 (8aea036e3bc08a3a0aba2ee4faf965318c0a835b):

  • sundials/7.1.1:
    CI failed to create some packages (All logs)

    Logs for packageID 1ece368f8df055498f0fff890d9911026f4778cc:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.cppstd=17
    compiler.libcxx=libstdc++11
    compiler.version=11
    os=Linux
    [options]
    */*:shared=False
    
    [...]
    -- C standard set to 99
    -- C extensions set to ON
    -- Performing Test SUNDIALS_C_COMPILER_HAS_BUILTIN_EXPECT
    -- Performing Test SUNDIALS_C_COMPILER_HAS_BUILTIN_EXPECT - Success
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ATTRIBUTE_ASSUME
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ATTRIBUTE_ASSUME - Failed
    -- Performing Test SUNDIALS_C_COMPILER_HAS_BUILTIN_ASSUME
    -- Performing Test SUNDIALS_C_COMPILER_HAS_BUILTIN_ASSUME - Failed
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ASSUME
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ASSUME - Failed
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ATTRIBUTE_UNUSED
    -- Performing Test SUNDIALS_C_COMPILER_HAS_ATTRIBUTE_UNUSED - Success
    -- Looking for POSIX timers... found
    -- Performing Test COMPILER_HAS_DEPRECATED_MSG
    -- Performing Test COMPILER_HAS_DEPRECATED_MSG - Success
    -- Appending C RELEASE flags
    -- Looking for sgemm_
    -- Looking for sgemm_ - not found
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
    -- Looking for pthread_create in pthreads
    -- Looking for pthread_create in pthreads - not found
    -- Looking for pthread_create in pthread
    -- Looking for pthread_create in pthread - found
    -- Found Threads: TRUE
    -- Looking for sgemm_
    -- Looking for sgemm_ - not found
    -- Looking for sgemm_
    -- Looking for sgemm_ - found
    -- Found BLAS: /home/conan/workspace/prod-v2/bsr/85963/cffbb/p/openbaa3d724cb6e26/p/lib/libopenblas.a;-lpthread
    -- Looking for cheev_
    -- Looking for cheev_ - not found
    CMake Error at /home/conan/workspace/prod-v2/bsr/85963/cffbb/p/cmakefaa1321642d5b/p/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
      Could NOT find LAPACK (missing: LAPACK_LIBRARIES)
    Call Stack (most recent call first):
      /home/conan/workspace/prod-v2/bsr/85963/cffbb/p/cmakefaa1321642d5b/p/share/cmake-3.30/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
      /home/conan/workspace/prod-v2/bsr/85963/cffbb/p/cmakefaa1321642d5b/p/share/cmake-3.30/Modules/FindLAPACK.cmake:796 (find_package_handle_standard_args)
      cmake/tpl/SundialsLapack.cmake:50 (find_package)
      cmake/SundialsSetupTPLs.cmake:122 (include)
      CMakeLists.txt:186 (include)
    
    
    -- Configuring incomplete, errors occurred!
    
    sundials/7.1.1: ERROR: 
    Package '1ece368f8df055498f0fff890d9911026f4778cc' build failed
    sundials/7.1.1: WARN: Build folder /home/conan/workspace/prod-v2/bsr/85963/cffbb/p/b/sundib47f7f990eb68/b/build/Release
    ERROR: sundials/7.1.1: Error in build() method, line 224
    	cmake.configure()
    	ConanException: Error 1 while executing
    
  • sundials/5.3.0:
    Didn't run or was cancelled before finishing

  • sundials/6.7.0:
    Didn't run or was cancelled before finishing

  • sundials/5.8.0:
    Didn't run or was cancelled before finishing

  • sundials/5.4.0:
    Didn't run or was cancelled before finishing

  • sundials/5.2.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Version 0.3.27 fails to cross-compile with

lapack-netlib/SRC/spstrf.c:830:43: error: passing argument 1 of ‘dmaxloc_’ from incompatible pointer type [-Wincompatible-pointer-types]
@AbrilRBS AbrilRBS removed their assignment Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants