Bump guava to 33.2.1-jre latest of right now to fix vulnerabilities. #223
Conversation
|
@v1r3n Checks are not triggering, do we need to do anything? |
|
@v1r3n It looks like there are some flakey tests (I'm getting the same on master. Is re-running builds and babysitting it something I can do? |
|
|
||
| if (lastDiff == 0) { |
There was a problem hiding this comment.
I'm pretty sure this is what was making the tests flakey.
Tests consistently pass on my machine.
| } | ||
|
|
||
| while (true) { | ||
| long currentDiff = |
There was a problem hiding this comment.
This whole logic could be simplified a fair bit, so I went ahead and did that while I was trying to figure out what was going wrong.
|
@v1r3n Would it be possible for me to have access to running the workflows? There seems to be some level of flakeyness. I'm happy to work on fixing this, but all tests are passing for me locally. |
|
@v1r3n looks like tests pass, would it be possible to merge this please? |
|
@v1r3n Is this OK to merge now? |
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
Bumped guava to 33.2.1-jre to fix up vulnerabilitites
Alternatives considered
None, this is just a version bump