-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump guava to 33.2.1-jre latest of right now to fix vulnerabilities. #223
Merged
v1r3n
merged 2 commits into
conductor-oss:main
from
aradu-atlassian:dependency/bump-guava
Aug 9, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -94,25 +94,11 @@ private List<Map<String, Object>> queryDb(String query) throws SQLException { | |
|
||
private void waitForCacheFlush() throws InterruptedException { | ||
long startTime = System.currentTimeMillis(); | ||
long lastDiff = | ||
System.currentTimeMillis() - ((PostgresPollDataDAO) pollDataDAO).getLastFlushTime(); | ||
long lastFlushTime = ((PostgresPollDataDAO) pollDataDAO).getLastFlushTime(); | ||
|
||
if (lastDiff == 0) { | ||
return; | ||
} | ||
|
||
while (true) { | ||
long currentDiff = | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This whole logic could be simplified a fair bit, so I went ahead and did that while I was trying to figure out what was going wrong. |
||
System.currentTimeMillis() | ||
- ((PostgresPollDataDAO) pollDataDAO).getLastFlushTime(); | ||
|
||
if (currentDiff < lastDiff || System.currentTimeMillis() - startTime > 1000) { | ||
return; | ||
} | ||
|
||
lastDiff = currentDiff; | ||
|
||
Thread.sleep(1); | ||
while (System.currentTimeMillis() - startTime < 1000 | ||
&& lastFlushTime <= ((PostgresPollDataDAO) pollDataDAO).getLastFlushTime()) { | ||
Thread.sleep(10); | ||
} | ||
} | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this is what was making the tests flakey.
Tests consistently pass on my machine.