fix: only perform lancedb cpu check for linux

[Patrick-Erichsen]

Description

Second attempt at #3551

Addresses #940 (comment) (and many others)

cc @mjkaye

[netlify]

✅ Deploy Preview for continuedev canceled.

Name	Link
🔨 Latest commit	9de923f
🔍 Latest deploy log	https://app.netlify.com/sites/continuedev/deploys/67ab9759a556f800082c10e1

[mjkaye]

I've conducted some testing today and, as @libandreas pointed out in #3551 (comment) , the VSCode extension crashes before reaching the CPU check. The issues causing these crashes align with what I noted in my previous comment on PR #3714 (please note that line numbers might have shifted slightly) - #3714 (comment) .

The main challenge will be to conditionally import CodebaseIndexer in core.ts, or manage the LanceDB related code within CodebaseIndexer, based on the CPU check. As ever, I'm happy to test more PRs.

[Patrick-Erichsen]

@mjkaye @libandreas - fresh updates to test out! I've moved the dynamic import logic higher up into the actual LanceDB index class and put some additional safeguards in the places we import that class.

Also @mjkaye I took your advice and switches to a more standard fs.readFileSync to read the contents of /proc/cpuinfo: https://github.com/continuedev/continue/pull/3883/files#diff-e825622a526d234083e4159a3399276bde238738984b17d26fe93ca77a0d0d50R134

[libandreas]

Hi,

I downloaded your source code and installed the current VSIX, and I successfully bypassed the crash and fell into the unsupported CPU scenario. This is a very good step.

However, I encountered some issues, but the plugin is working now:

Activation errors, which are from the original source.
The next issues I get only from that source code:
The command 'continue.openMorePage' is not found when I press the settings icon on the GUI, but the config is recognized. I get migration issues, which I don't know what that is.
The command 'continue.focusEdit' is not found when I press Ctrl+I.
The command 'continue.focusContinueInput' is not found.
The command 'continue.viewHistory' is not found.
And so on..
While the commands work in the pre-release version is not wrorking on the custom brunch, I don't know if I made something wrong when compiling or if there is a source code problem. I am just reporting that.
@Patrick-Erichsen

[mjkaye]

Thank you for addressing this issue with such diligence, @Patrick-Erichsen. I've been testing the latest changes and am pleased to report that the extension no longer crashes on my older CPU setup—this is a significant improvement.

I noted that the extension informed me about disabling indexing, which is a nice feature. It might be helpful to direct users to some documentation for more context instead of pointing them to the GitHub issue.

In terms of functionality, I've conducted some basic tests and everything seems to be working smoothly:

• Chatting about code
• Tab completion
• Editing code using Ctrl+I

Everything is functioning as expected.

If there are any other specific tests you'd like me to perform, please let me know. Your attention to detail has been greatly appreciated.

Thanks again for your hard work on this.

For reference, @libandreas, this is the way I set up my environment for testing:

1. git clone https://github.com/continuedev/continue.git -b pe/unsupported-cpu-check-pt-2 into a new directory
2. Remove (or rename) my .vscode-oss (or .vscode) directory, to make sure I'm starting fresh
3. Remove (or rename) my .continue directory, to make sure I'm starting fresh
4. Run VSCodium (or VSCode)
5. Open the folder holding the cloned code (from step 1)
6. Follow the instructions from https://github.com/continuedev/continue/blob/main/CONTRIBUTING.md#vs-code

I'd also be interested to hear your suggestions for tests I can perform, @libandreas .

[Patrick-Erichsen]

@mjkaye appreciate the feedback, I improved the notification and updated the link to point to a new section in our FAQ. And thank you as well for all the testing throughout the PR process here!

Based on this I think we're good to merge and get a second round of feedback from folks on the upstream issues.

[libandreas]

lets wait for the merge, thank you, i was waiting 6 months for that fix