Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

155 abstract syntax documentation #257

Merged
merged 18 commits into from
Aug 4, 2024
Merged

Conversation

jbcaillau
Copy link
Member

No description provided.

@jbcaillau jbcaillau linked an issue Aug 1, 2024 that may be closed by this pull request
1 task
@github-actions github-actions bot requested a review from ocots August 1, 2024 22:46
@jbcaillau
Copy link
Member Author

jbcaillau commented Aug 2, 2024

@ocots Related issue: control-toolbox/CTDirect.jl#69 (comment)

Forcing linear_solver="mumps" in Goddard tuto right now; this is indeed what happens on GitHub runners, not on my machine locally (I have installed HSL).

@jbcaillau
Copy link
Member Author

jbcaillau commented Aug 2, 2024

@ocots BTW stupid trick to avoid duplicating docs when building the documentation locally (which needs to add the current package, contrary to what happens on runners):

julia> Pkg.add("OptimalControl"); include("make.jl"); Pkg.rm("OptimalControl")

@jbcaillau jbcaillau mentioned this pull request Aug 2, 2024
@PierreMartinon
Copy link
Member

@jbcaillau I guess you'll have to rename tutorial-nlp.md.foo back manually

@jbcaillau
Copy link
Member Author

@PierreMartinon yes: local build (and draft PR) failing otherwise

@jbcaillau jbcaillau marked this pull request as ready for review August 4, 2024 15:02
@jbcaillau
Copy link
Member Author

@ocots please review and merge

@PierreMartinon @gergaud do not hesitate to add further comments, examples to the tutorial

@ocots
Copy link
Member

ocots commented Aug 4, 2024

@jbcaillau J'ai relu ton nouveau tuto. Top!

J'en ai profité pour restructurer. J'espère que ça ira pour toi. En gros, ça ne change aucun liens. C'est juste du point de vue du menu. On aura :

Capture d’écran 2024-08-04 à 23 10 00

@jbcaillau jbcaillau merged commit 2ae8993 into main Aug 4, 2024
2 checks passed
@jbcaillau jbcaillau deleted the 155-abstract-syntax-documentation branch August 4, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abstract syntax documentation
3 participants