Increase screen brightness to 100% when opening QR-codes

[rkw95]

See corona-warn-app/cwa-wishlist#571, as I could not transfer the issue from the wishlist repo to this repo.

---

Internal Tracking ID: EXPOSUREAPP-8224

[Ein-Tim]

Is a separate issue for this really necessary?

[rkw95]

I wanted to implement this feature. In order to reference it easier inside this repo, I created this issue.

[rkw95]

Can someone with the necessary permissions assign me this issue so I can propose a solution?

[dsarkar]

Hi @rkw95, thanks for participating here. Are you offering code or even a PR for an implementation on Android? Just to make you aware: Usually in this project parity between iOS and Android is maintained, i.e. there might be a delay in releasing this feature until a corresponding feature for iOS has been prepared.

---

Corona-Warn-App Open Source Team

[rkw95]

I'm very new to Android / Kotlin programming, (I have other coding experience), but I got it working on my personal phone. So I wanted to share my solution. I do not know if my implementation works also for iOS.

[dsarkar]

@rkw95 ok, thanks. I suggest to share your code or PR here in this repository, and then the dev team might have a look at it.

[rkw95]

@dsarkar how can I push to the repo? I have a local git branch named feature/increase_scanablity_issue_4606 with my proposed solution but I don't have the permission to push it.

[dsarkar]

@rkw95

I understand you have a fork of the cwa-app-android repository.

Go to
https://github.com/YOUR_FORK/cwa-app-android/branches

Next to your new feature branch press "New pull request"

Then choose
base repository: /corona-warn-app/cwa-app-android
base: branch 2.16.x or later

head repository: /YOUR_FORK/cwa-app-android
compare: your feature branch

[dsarkar]

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

[MikeMcC399]

@rkw95
I can see that you have a fork https://github.com/rkw95/cwa-app-android , however there is no branch feature/increase_scanablity_issue_4606 in that fork.

If you have a standard setup you would need to execute
git push origin feature/increase_scanablity_issue_4606
from the command line.

There is a typo in your branch name. You might want to rename the branch before you push it.
scanablity => scanability

[rkw95]

@dsarkar Thanks for your help!

@MikeMcC399 Thanks for pointing out the typo. The branch was still local, I now pushed it and I will create a merge request.

[MikeMcC399]

@rkw95
You will need to rebase on 2.16.x
git rebase release/2.16.x feature/increase_scanability_issue_4606
then
git push origin feature/increase_scanability_issue_4606 --force
otherwise your pull request will not be right.

[rkw95]

Ok, I rebased and created a pull request. :)

[dsarkar]

Good morning @MikeMcC399, Thanks for assisting here!
Good morning @rkw95, Thanks for the PR!

[MikeMcC399]

@rkw95

Congratulations on getting your PR accepted! It was rolled out with version 2.16.

I tested it on CWA Android 2.16.2 and I confirmed it still works in 2.17.2.

1. Depending on device, set brightness to 1/4 full and disable autobrightness
2. Scan 2/2 vaccination certificate
3. From Status screen, tap on Certificates
4. Tap on QR code
5. Scroll down to Vaccination Certificate and tap on it
6. Tap on QR code
7. Confirm that full-screen QR code is shown and that the display is bright

Would you like to close this issue now that it is resolved and rolled out?

[eltos]

Hi everyone,
while #4624 is really nice, I think this can be improved even further for everyday usage of the app:

Usually people will just go to the certificate tab and present the QR codes already displayed there when asked for. If the brightness is insufficient, I suspect people will click through steps 4-7 (if they are even aware of this possibility), and instead just increase the brightness from the notification bar (which is faster and much more intuitive).

Therefore, I propose to add a toggle action item to the toolbar in the certificates tab (as in the screenshot below). This will allow to quickly increase the screen brightness with only a single tap if required. This has several advantages:

• Intuitive to the user
• Fast (which is especially important to reduce queuing at entrance controls)
• Not disturbing, since it's not enabled by default

If you want, I'd volunteer to propose an implementation and submit a PR on the matter.

Screenshot

[MikeMcC399]

@rkw95
Since the original issue has been resolved, it probably makes sense to close this one.

For clarity, the suggestion from @eltos in #4606 (comment) would more easily be tracked in a new issue.

[eltos]

For clarity, the suggestion from @eltos in #4606 (comment) would more easily be tracked in a new issue.

I agree, please see corona-warn-app/cwa-wishlist#857 @MikeMcC399

[MikeMcC399]

@rkw95 / @dsarkar

Will either of you be closing this issue?