This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Increase screen brightness when QrCode is in full screen Mode (EXPOSUREAPP-8224) #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 22, 2021 19:22
… code in full screen mode and setting brightness back to old brighness level when leaving full screen mode
added 2 commits
December 22, 2021 20:09
rkw95
changed the title
mtwalli
changed the title
mtwalli
added
community
mtwalli
changed the title
mtwalli
reviewed
Dec 22, 2021
| @@ -25,6 +25,8 @@ | |||
|
|
|||
| <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" /> | |||
|
|
|||
| <uses-permission android:name="android.permission.WRITE_SETTINGS" tools:ignore="ProtectedPermissions" /> | |||
|
|
|||
There was a problem hiding this comment.
this won't be necessary, please see my suggestion below in QrCodeFullScreenFragment file ?
| startActivity(intent) | ||
| } | ||
| } | ||
|
|
| Settings.System.SCREEN_BRIGHTNESS, | ||
| this.brightness | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please revert the changes in here and just try the following snippet ?
override fun onResume() {
super.onResume()
keepScreenOn(on = true)
}
override fun onPause() {
super.onPause()
keepScreenOn(on = false)
}
private fun keepScreenOn(on: Boolean) = with(requireActivity().window) {
if (on) addFlags(FLAG_KEEP_SCREEN_ON) else clearFlags(FLAG_KEEP_SCREEN_ON)
attributes = attributes.apply { screenBrightness = if (on) 1f else -1f }
}
This reverts commit 9d8fe50.
|
@rkw95 if you don't have the time to address the comments, please let us know so we can take care of it ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented setting screen brightness to 100% while a QR code is shown in full screen mode for better scanability. Does not apply to other views when a QR code is shown but not as full screen.
Drawback might be the necessity to give the cwa the permission to write system settings.
See #4606 for more information.