Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dappId to hooks schema #66

Merged
merged 1 commit into from
Oct 3, 2024
Merged

feat: add dappId to hooks schema #66

merged 1 commit into from
Oct 3, 2024

Conversation

shoom3301
Copy link
Contributor

We need an identificator to match hooks from order with dapp that was used to create the hooks.
There is a new dappid field in hook schema, which is an optional hex string with 64 length.

Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except that the schema version is wrong.
Unless that's on purpose?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next schema version should be 1.3.0
image

@shoom3301
Copy link
Contributor Author

Thank you @alfetopito !
Fixed it

@shoom3301 shoom3301 merged commit c8c6b90 into main Oct 3, 2024
6 checks passed
@shoom3301 shoom3301 deleted the feat/hook-dappId branch October 3, 2024 07:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants