Add Copium Capital MEV Blocker kickbacks #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Aug 21, 2024
src/constants.py
Outdated
Comment on lines
42
to
43
| COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS = "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b" | ||
| COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS = "0x008300082C3000009e63680088f8c7f4D3ff2E87" |
There was a problem hiding this comment.
Is it possible to write the code as
Suggested change
| COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS = "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b" | |
| COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS = "0x008300082C3000009e63680088f8c7f4D3ff2E87" | |
| MEV_BLOCKER_KICKBACKS_ADDRESS = [ | |
| "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b", | |
| "0x008300082C3000009e63680088f8c7f4D3ff2E87", | |
| ] |
And also add all other external drivers?
The rest of the code would need to be adapted as well.
There was a problem hiding this comment.
Yeah good suggestion, just pushed an update
Comment on lines
43
to
47
| eth_kickbacks = None | ||
| if cow_dao_total_eth_kickbacks is not None: | ||
| eth_kickbacks = cow_dao_total_eth_kickbacks | ||
| if copium_capital_total_eth_kickbacks is not None: | ||
| eth_kickbacks = copium_capital_total_eth_kickbacks |
There was a problem hiding this comment.
Suggested change
| eth_kickbacks = None | |
| if cow_dao_total_eth_kickbacks is not None: | |
| eth_kickbacks = cow_dao_total_eth_kickbacks | |
| if copium_capital_total_eth_kickbacks is not None: | |
| eth_kickbacks = copium_capital_total_eth_kickbacks | |
| eth_kickbacks = ( | |
| cow_dao_total_eth_kickbacks or copium_capital_total_eth_kickbacks | |
| ) |
Merged
harisang
added a commit
that referenced
this pull request
Aug 21, 2024
Ran into some issues in PR #112 so decided to update the python version. --------- Co-authored-by: Felix Henneke <[email protected]>
Ran into some issues in PR #112 so decided to update the python version. --------- Co-authored-by: Felix Henneke <[email protected]>
This reverts commit 783bf5d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the current address where Copium receives kickbacks, for monitoring purposes.