Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Copium Capital MEV Blocker kickbacks #112

Merged
merged 7 commits into from
Aug 21, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@

# relevant addresses
SETTLEMENT_CONTRACT_ADDRESS = "0x9008D19f58AAbD9eD0D60971565AA8510560ab41"
MEV_BLOCKER_KICKBACKS_ADDRESS = "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b"
COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS = "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b"
COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS = "0x008300082C3000009e63680088f8c7f4D3ff2E87"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to write the code as

Suggested change
COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS = "0xCe91228789B57DEb45e66Ca10Ff648385fE7093b"
COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS = "0x008300082C3000009e63680088f8c7f4D3ff2E87"
MEV_BLOCKER_KICKBACKS_ADDRESS = [
"0xCe91228789B57DEb45e66Ca10Ff648385fE7093b",
"0x008300082C3000009e63680088f8c7f4D3ff2E87",
]

And also add all other external drivers?

The rest of the code would need to be adapted as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah good suggestion, just pushed an update


# requests
REQUEST_TIMEOUT = 5
Expand Down
24 changes: 18 additions & 6 deletions src/monitoring_tests/mev_blocker_kickbacks_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
from src.monitoring_tests.base_test import BaseTest
from src.apis.web3api import Web3API
from src.constants import (
MEV_BLOCKER_KICKBACKS_ADDRESS,
COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS,
COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS,
KICKBACKS_ALERT_THRESHOLD,
)

Expand All @@ -31,19 +32,30 @@ def run(self, tx_hash: str) -> bool:
if block_number is None:
return False

total_eth_kickbacks = self.web3_api.get_eth_transfers_by_block_range(
block_number, block_number, MEV_BLOCKER_KICKBACKS_ADDRESS
cow_dao_total_eth_kickbacks = self.web3_api.get_eth_transfers_by_block_range(
block_number, block_number, COW_DAO_MEV_BLOCKER_KICKBACKS_ADDRESS
)
if total_eth_kickbacks is None:
copium_capital_total_eth_kickbacks = (
self.web3_api.get_eth_transfers_by_block_range(
block_number, block_number, COPIUM_CAPITAL_MEV_BLOCKER_KICKBACKS_ADDRESS
)
)
eth_kickbacks = None
if cow_dao_total_eth_kickbacks is not None:
eth_kickbacks = cow_dao_total_eth_kickbacks
if copium_capital_total_eth_kickbacks is not None:
eth_kickbacks = copium_capital_total_eth_kickbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eth_kickbacks = None
if cow_dao_total_eth_kickbacks is not None:
eth_kickbacks = cow_dao_total_eth_kickbacks
if copium_capital_total_eth_kickbacks is not None:
eth_kickbacks = copium_capital_total_eth_kickbacks
eth_kickbacks = (
cow_dao_total_eth_kickbacks or copium_capital_total_eth_kickbacks
)


if eth_kickbacks is None:
return False
log_output = "\t".join(
[
"MEV Blocker kickbacks test:",
f"Tx Hash: {tx_hash}",
f"Kickback: {total_eth_kickbacks:.5f}ETH",
f"Kickback: {eth_kickbacks:.5f}ETH",
]
)
if total_eth_kickbacks >= KICKBACKS_ALERT_THRESHOLD:
if eth_kickbacks >= KICKBACKS_ALERT_THRESHOLD:
self.alert(log_output)
else:
self.logger.info(log_output)
Expand Down
Loading