Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compare order params properly #168

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: compare order params properly #168

merged 1 commit into from
Dec 3, 2024

Conversation

shoom3301
Copy link
Contributor

The hypothesis works, so we can confidently add the getAreConditionalOrderParamsEqual() call

image

@shoom3301 shoom3301 requested a review from a team December 3, 2024 12:28
@shoom3301 shoom3301 self-assigned this Dec 3, 2024
anxolin
anxolin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, but you think this was happening in re-orgs (when we re-apply an order) or somehow it was happening more often?

@shoom3301 shoom3301 merged commit 5ecab03 into main Dec 3, 2024
4 checks passed
@shoom3301 shoom3301 deleted the fix/order-param-check branch December 3, 2024 12:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anxolin anxolin anxolin approved these changes

Assignees

@shoom3301 shoom3301

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shoom3301 @anxolin