Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compare order params properly #168

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: compare order params properly #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 4 additions & 18 deletions src/domain/events/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,25 +206,11 @@ function add(
// Iterate over the conditionalOrders to make sure that the params are not already in the registry
for (const conditionalOrder of conditionalOrders?.values() ?? []) {
// Check if the params are in the conditionalOrder
if (conditionalOrder) {
const areConditionalOrderParamsEqual =
getAreConditionalOrderParamsEqual(conditionalOrder.params, params);
const areConditionalOrderParamsEqual =
!!conditionalOrder &&
getAreConditionalOrderParamsEqual(conditionalOrder.params, params);

// TODO: delete this log after testing
if (
areConditionalOrderParamsEqual &&
conditionalOrder.params !== params
) {
log.error(
"Conditional order params are equal but not the same",
conditionalOrder.id,
JSON.stringify(params)
);
}
}

// TODO: this is a shallow comparison, should we do a deep comparison?
if (conditionalOrder.params === params) {
if (areConditionalOrderParamsEqual) {
exists = true;
break;
}
Expand Down
Loading