Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update lint config #2683

Merged
merged 4 commits into from
Aug 14, 2024
Merged

feat: update lint config #2683

merged 4 commits into from
Aug 14, 2024

Conversation

acezard
Copy link
Contributor

@acezard acezard commented Aug 12, 2024

This will match at least the configuration used on cozy-store.

It upgrades eslint-config-cozy-app. This requires to install a number of dependencies.

Prettier also had to be fixed to a version. We used the version that was already implicitly used (2.6.0).

Copy link
Contributor

@cballevre cballevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 but check @JF-Cozy if he is okay with this PR before merge

@JF-Cozy
Copy link
Collaborator

JF-Cozy commented Aug 14, 2024

pour le commit fix: handle auto fixable lint errors je pense qu'il n'y a aucun changement de code, que du lint --fix ? Dans ces cas là j'aime bien le mettre en "commit description" genre "no code change"

@JF-Cozy
Copy link
Collaborator

JF-Cozy commented Aug 14, 2024

pourquoi ces merges ?
image

Faudrait plutôt rebase la branche depuis master ce serait plus clair.

@acezard
Copy link
Contributor Author

acezard commented Aug 14, 2024

pour le commit fix: handle auto fixable lint errors je pense qu'il n'y a aucun changement de code, que du lint --fix ? Dans ces cas là j'aime bien le mettre en "commit description" genre "no code change"

ok je mets

@acezard acezard force-pushed the feat--update-lint-config branch from 5af2ac7 to 59a8994 Compare August 14, 2024 12:56
@acezard acezard force-pushed the feat--update-lint-config branch from 59a8994 to 24d5571 Compare August 14, 2024 12:56
@acezard acezard merged commit ec1c677 into master Aug 14, 2024
5 checks passed
@acezard acezard deleted the feat--update-lint-config branch August 14, 2024 13:17
@cozy-bot
Copy link

🎉 This PR is included in version 111.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants