fix(grafana): use relative dashboard path #874
Merged
+5
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
andrewazores
force-pushed
the
relative-dashboard-ext-url
branch
from
a348ca1 to
dbee86b
Compare
|
/build_test |
ebaron
approved these changes
Jun 7, 2024
|
|
andrewazores
force-pushed
the
relative-dashboard-ext-url
branch
from
f313a39 to
8a668b1
Compare
|
/build_test |
|
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit 9674189)
7 tasks
andrewazores
added a commit
that referenced
this pull request
Jun 7, 2024
andrewazores
added a commit
that referenced
this pull request
Jun 7, 2024
andrewazores
added a commit
that referenced
this pull request
Jun 7, 2024
Co-authored-by: Andrew Azores <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Related to #726
Description of the change:
Sets the
GRAFANA_DASHBOARD_EXT_URLto the simple relative/grafana/path, rather than the full Route URL.Motivation for the change:
Since Grafana and Cryostat are now deployed together behind a common auth proxy instance, the client accesses Grafana simply by navigating to
/grafana/on the Cryostat UI URL. This change simplifies the setup so that there are now no more references to the full Route URL in the Deployment, so it is overall more dynamic and flexible. This will support cases where the user wishes to deploy Cryostat on a custom domain or custom subpath.