Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): contextual override for WebSocket notification URL #1544

Merged
merged 17 commits into from
Jan 30, 2025

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Jan 29, 2025

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1542

Description of the change:

See #1542. This is a similar change, but for determining the WebSocket server URL rather than the HTTP API base.

Motivation for the change:

Working toward console plugin being able to establish a WebSocket notification connection through the plugin proxy.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@andrewazores andrewazores requested review from aptmac and removed request for aptmac January 29, 2025 19:14
@andrewazores andrewazores marked this pull request as draft January 29, 2025 20:18
@andrewazores andrewazores merged commit e12c454 into cryostatio:main Jan 30, 2025
12 checks passed
@andrewazores andrewazores deleted the contextual-notifications branch January 30, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants