-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(notifications): contextual override for WebSocket notification URL #1544
Merged
andrewazores
merged 17 commits into
cryostatio:main
from
andrewazores:contextual-notifications
Jan 30, 2025
Merged
fix(notifications): contextual override for WebSocket notification URL #1544
andrewazores
merged 17 commits into
cryostatio:main
from
andrewazores:contextual-notifications
Jan 30, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b45db55
to
1d3897e
Compare
Merged
7 tasks
aptmac
approved these changes
Jan 30, 2025
…side of render tree below a provider anyway
…ext outside of render tree below a provider anyway
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to #1542
Description of the change:
See #1542. This is a similar change, but for determining the WebSocket server URL rather than the HTTP API base.
Motivation for the change:
Working toward console plugin being able to establish a WebSocket notification connection through the plugin proxy.
How to manually test: