Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(itest): updated UploadRecordingTest to handle the redirects to V3 endpoints #150

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

lkonno
Copy link
Contributor

@lkonno lkonno commented Nov 8, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #42

Description of the change:

Created new methods to handle the redirects to new V3 endpoints for the UploadRecordingTest

Notes: It will fail during the create recording ("/api/v1/targets/%s/recordings") as it is expecting 201 and it is currently is returning 200 (updated Recordings to return 201)
The original test to delete recording was expecting 200 code, but I think that the current 204 makes more sense.

Motivation for the change:

vertx does not follow redirects for non GET and HEAP methods

How to manually test:

mvn package

@lkonno lkonno requested a review from andrewazores November 8, 2023 01:44
@andrewazores andrewazores merged commit fb24f45 into cryostatio:main Nov 8, 2023
32 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants