Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing excess fields on DocumentStep #119

Merged
merged 6 commits into from
Jan 25, 2024
Merged

fixing excess fields on DocumentStep #119

merged 6 commits into from
Jan 25, 2024

Conversation

alexviquez
Copy link
Member

We add a excess field function to remove aditional data to the VerificationDocumentStep class

@alexviquez alexviquez added the enhancement New feature or request label Jan 24, 2024
@alexviquez alexviquez requested a review from rogelioLpz January 24, 2024 18:14
@alexviquez alexviquez self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Merging #119 (b730338) into master (001eec7) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
+ Coverage   98.03%   98.09%   +0.05%     
==========================================
  Files          11       12       +1     
  Lines         357      367      +10     
==========================================
+ Hits          350      360      +10     
  Misses          7        7              
Flag Coverage Δ
unittests 98.09% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
mati/resources/verifications.py 100.00% <ø> (ø)
mati/types/enums.py 96.06% <100.00%> (+0.30%) ⬆️
mati/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 001eec7...b730338. Read the comment docs.

rogelioLpz
rogelioLpz previously approved these changes Jan 25, 2024
@alexviquez alexviquez merged commit ffca913 into master Jan 25, 2024
8 checks passed
@alexviquez alexviquez deleted the excess-fields branch January 25, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants