Merge branch 'master' into bugfix/CI

curso-r · Dec 26, 2021 · 119f1f5 · 119f1f5
2 parents 2a38bea + 60aade5
commit 119f1f5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/R/catboost.R b/R/catboost.R
@@ -189,7 +189,7 @@ add_boost_tree_catboost <- function() {
   parsnip::set_model_arg(
     model = "boost_tree",
     eng = "catboost",
-    parsnip = "sample_size",
+    parsnip = "sample_prop",
     original = "subsample",
     func = list(pkg = "dials", fun = "sample_prop"),
     has_submodel = FALSE

diff --git a/R/lightgbm.R b/R/lightgbm.R
@@ -166,7 +166,7 @@ add_boost_tree_lightgbm <- function() {
   parsnip::set_model_arg(
     model = "boost_tree",
     eng = "lightgbm",
-    parsnip = "sample_size",
+    parsnip = "sample_prop",
     original = "bagging_fraction",
     func = list(pkg = "dials", fun = "sample_prop"),
     has_submodel = FALSE

diff --git a/vignettes/working-with-lightgbm-catboost.Rmd b/vignettes/working-with-lightgbm-catboost.Rmd
@@ -11,6 +11,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
+  eval = FALSE,
   warning = FALSE,
   message = FALSE,
   eval = FALSE