-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/figuredbass object #1614
Merged
mscuthbert
merged 10 commits into
cuthbertLab:master
from
mxordn:feature/figuredbass-object
Jul 2, 2023
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b7ae781
introduces FiguredBass object and makes some changes to Notation and …
94f76b4
indentation update
d6ee784
corrections to notation PR #1614
7b099f2
added requested changes to figuredbass and notation object
c4609bf
first commit for fixing issues in place.
mscuthbert c847113
move FiguredBass object to figuredBass.FiguredBass
mscuthbert 2672974
Merge branch 'master' into pr/1614
mscuthbert 70f9f2c
lint and mypy
mscuthbert f232f9d
Cover uncovered test lines. https://coveralls.io/builds/60910555
mscuthbert 88b8ed9
reuse your setters, Myke!
mscuthbert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is immediately wiped out -- mistake? Not tested enough.