Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports ttl constructor option with external redis instances #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Supports ttl constructor option with external redis instances #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,11 @@ const redisStore = (...args) => {
redisCache = new Redis(...args);
}

const storeArgs = redisCache.options;
const storeArgs = {
...redisCache.options,
ttl: args.length > 0 ? args[0].ttl : undefined
};


let self = {
name: 'redis',
Expand Down
6 changes: 5 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,11 @@ const redisStore = (...args) => {
redisCache = new Redis(...args);
}

const storeArgs = redisCache.options;
const storeArgs = {
...redisCache.options,
ttl: args.length > 0 ? args[0].ttl : undefined
};


let self = {
name: 'redis',
Expand Down
22 changes: 22 additions & 0 deletions test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,28 @@ describe('set', () => {
});
});

it('should respect the ttl option when supplied an external redis instance', (done) => {
const externalRedisInstanceCache = cacheManager.caching({
store: redisStore,
redisInstance: new Redis({
host: config.host,
port: config.port,
password: config.password,
db: config.db,
}),
ttl: 123
});

externalRedisInstanceCache.set('foo', 'bar', (err) => {
expect(err).toEqual(null);
redisCache.ttl('foo', (err, ttl) => {
expect(err).toEqual(null);
expect(ttl).toEqual(123);
done();
});
});
});

it('should not be able to store a null value (not cacheable)', (done) => {
redisCache.set('foo2', null, (err) => {
if (err) {
Expand Down