Refactor logo structure. #1099
Merged
Refactor logo structure. #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasseStaus
assigned kasperg, rasben and kasperbirch1 and unassigned kasperg, rasben and kasperbirch1
This updates the logo structure with the new structure from the designsystem. The intension is the use the same logo template everywhere the logo is necessary, and keep the href logic inside this template. This also adds an aria-label as requested in a seperate ticket: DDFFORM-750 DDFFORM-696
rasben
reviewed
May 13, 2024
I'll remove that commit once it's tested. I have just added it so they can test the changes 👍 |
rasben
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the logo structure with the new structure from the designsystem.
The intension is the use the same logo template everywhere the logo is necessary, and keep the href logic inside this template.
This also adds an aria-label as requested in a seperate ticket: DDFFORM-750
DDFFORM-696
Link to issue
This PR covers two tickets:
DDFFORM-696
DDFFORM-709
Depends on PR in design system: danskernesdigitalebibliotek/dpl-design-system#621
Description
This PR updates the markup for the logo template.
The aim is to ensure that the logo is rendered the same way in both header/footer and handles the redirect to the frontpage.
This also adds an aria-label as requested in DDFFORM-709