Refactor logo into logo-link #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LasseStaus
force-pushed
the
DDFFORM-696
branch
2 times, most recently
from
20ec28a to
76307eb
Compare
kasperbirch1
reviewed
May 6, 2024
src/stories/Library/logo/Logo.tsx
Outdated
| <figure className="logo-link__content"> | ||
| {hasImage && <img className="logo" src={logo} alt={altText} />} | ||
| <div | ||
| className={`logo-link__description ${ |
There was a problem hiding this comment.
We should probably use clsx here, not that it makes a big difference
The current logo CSS / markup is outdated. This refactors the logo component so that it displays the image, and / or the library name / place accordingly. This also moves css for the logo away from "Header", as the logo is used elsewhere that the header as well. Additionally the story has been updated, and any component using the <logo/> component has has its' props updated in accordance with the changes. This also introduces an aria-label for the logo, which was requested in a seperate ticket: DDFFORM-750 DDFFORM-696
rasben
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
PR dækker to tickets:
DDFFORM-696
DDFFORM-709
Depends on PR in cms: danskernesdigitalebibliotek/dpl-cms#1099
Description
This PR refators the logo markup/css.
The component should now be updated to handle the redirect to frontpage, include an aria-label as requested in DDFFORM-709, and display the image/ fallback of library name and place accordingly.
I have left the UI changes unaccepted until reviewed.