Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of reservation labels #341

Conversation

spaceo
Copy link
Contributor

@spaceo spaceo commented Nov 17, 2023

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-278
https://reload.atlassian.net/browse/DDFLSBP-279

Description

They were just put in roughly everywhere needed in dpl-react so the different views in group-modal and reservation-list had to be adjusted.

Screenshot of the result

image

They were just put in roughly everywhere needed in dpl-react so the
different views in group-modal and reservation-list had to be adjusted.
Copy link
Contributor

@Adamik10 Adamik10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Before I can approve this, though, please have a look at all the UI tests and consider whether these changes had any unpredictable effects on other views - I believe there are over 30 screens that need to be reviewed.

@@ -80,3 +79,14 @@
display: none;
}
}

.list-materials__arrow {
margin-left: $s-xl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it that you're using the variables we have :)))

@spaceo spaceo changed the base branch from develop to demo_2023-48-0 November 20, 2023 11:13
@spaceo spaceo merged commit 2b4afa5 into danskernesdigitalebibliotek:demo_2023-48-0 Nov 21, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants