Add EventPage + EventHeader
#353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
DDFFORM-14-oprette-arrangement
branch
from
909b05c to
834c667
Compare
kasperbirch1
force-pushed
the
DDFFORM-14-oprette-arrangement
branch
2 times, most recently
from
092a3fb to
5170a07
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 30, 2023
This should be reverted when the pull requests in dpl-design-system are merged. danskernesdigitalebibliotek/dpl-design-system#353
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 30, 2023
This should be reverted when the pull requests in dpl-design-system are merged. danskernesdigitalebibliotek/dpl-design-system#353
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Nov 30, 2023
This should be reverted when the pull requests in dpl-design-system are merged. danskernesdigitalebibliotek/dpl-design-system#353
kasperbirch1
force-pushed
the
DDFFORM-14-oprette-arrangement
branch
from
5170a07 to
aed6a2b
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 1, 2023
This should be reverted when the pull requests in dpl-design-system are merged. danskernesdigitalebibliotek/dpl-design-system#353
kasperg
requested changes
Dec 1, 2023
kasperbirch1
force-pushed
the
DDFFORM-14-oprette-arrangement
branch
2 times, most recently
from
c6f529e to
305f262
Compare
kasperbirch1
added a commit
to danskernesdigitalebibliotek/dpl-cms
that referenced
this pull request
Dec 3, 2023
This should be reverted when the pull requests in dpl-design-system are merged. danskernesdigitalebibliotek/dpl-design-system#353
kasperg
requested changes
Dec 4, 2023
Comment on lines
+22
to
+29
| .event-header__content { | ||
| display: grid; | ||
| grid-template-columns: $s-3xl 1fr $s-3xl; | ||
| grid-template-areas: | ||
| ". tag ." | ||
| ". date ." | ||
| ". title ." | ||
| "btn btn btn"; |
There was a problem hiding this comment.
As I read this you are creating padding for some areas using columns. That's creative.
Implemented a new SCSS mixin named 'container' to handle different container sizes: small, medium, and large. This mixin allows for dynamic styling based on the specified size parameter. Styles for 'small' and 'large' sizes are structured for future customization, while the 'medium' size is currently set with a max-width of 1440px and centered margin.
Introduced markup and CSS for `EventHeader`, now included in `EventPage`. Additionally, made small modifications to the `tag` component to allow the addition of extra CSS classes. In typography, I introduced a placeholder for `.text-header-h1` to facilitate future extension of this class
Enabling user experimentation with various images.
CSS handles uppercase transformation
-Removed the `className` property from the `Button` component due to redundancy. - Planned additional refactoring to extend the "button" classes within `event-header__button`
Extracted into a separate component to facilitate easy integration in diverse application areas.
…as` for content positioning. Removed unnecessary wrapper div in `.event-header__content` for better semantic structure
kasperbirch1
force-pushed
the
DDFFORM-14-oprette-arrangement
branch
from
305f262 to
2c7aa0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFFORM-14
Description
This pull request introduces two new components:
EventPageandEventHeader. These components are used for the event-related pages of our application.Screenshot of the result