Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich text + Re-factor layout max width as a mixin #390

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

rasben
Copy link
Contributor

@rasben rasben commented Dec 15, 2023

Make sure that rich-text has spacing and margin. DDFFORM-5

It worked in Storybook, but not in Drupal.
That is because Storybook adds its own wrapper, which made it appear
correct.


Add a layout-container mixin, and replace any existing max-widths.

@rasben rasben changed the base branch from develop to release/2023-51-0 December 15, 2023 13:31
@rasben rasben force-pushed the fix-rich-text branch 3 times, most recently from f21fa19 to 261ad33 Compare December 15, 2023 13:53
It worked in Storybook, but not in Drupal.
That is because Storybook adds its own wrapper, which made it appear
correct.
@rasben rasben marked this pull request as ready for review December 15, 2023 13:59
Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

@kasperbirch1 kasperbirch1 self-requested a review December 15, 2023 14:15
Copy link
Contributor

@kasperbirch1 kasperbirch1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

@rasben rasben changed the title Fix rich text Fix rich text + Re-factor layout max width as a mixin Dec 15, 2023
@rasben rasben force-pushed the fix-rich-text branch 2 times, most recently from 3fa0b6c to 07bcb85 Compare December 15, 2023 14:35
@rasben rasben merged commit fba0de5 into release/2023-51-0 Dec 15, 2023
9 checks passed
@rasben rasben deleted the fix-rich-text branch December 15, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants