Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rich text + Re-factor layout max width as a mixin #390

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix rich text + Re-factor layout max width as a mixin #390

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd485fb
Make sure that rich-text has spacing and margin. DDFFORM-5
rasben Dec 15, 2023
d721f58
Add a layout-container mixin, and replace any existing max-widths.
rasben Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/stories/Library/rich-text/rich-text.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

// Setting a max-width to increase readability for sentences.
max-width: $layout__max-width--text;
margin: auto;
rasben marked this conversation as resolved.
Show resolved Hide resolved
padding-left: $layout__page-padding;
padding-right: $layout__page-padding;

a {
@extend %text-inline-link;
Expand Down
2 changes: 1 addition & 1 deletion src/styles/scss/tools.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
@import "tools/variables.fonts";
@import "tools/variables.z-indexes";
@import "tools/variables.layout";
@import "tools/variables.spacings";
@import "tools/variables.layout";
@import "tools/variables.colors";
@import "tools/variables.breakpoints";
@import "tools/variables.typography";
Expand Down
4 changes: 4 additions & 0 deletions src/styles/scss/tools/variables.layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ $layout__max-width--large: 1440px;
$layout__max-width--text: 780px;
$layout__max-width--single-media: 896px;
$layout__max-width--multiple-medias: 1240px;

// Some elements should not go out to the edge of the screen on small screens.
// This is the padding that is always shown on the left and right.
$layout__page-padding: $s-xl;
Loading