DDFFORM 490 material grid #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2024
These changes aim to: - Ensure that the individual recommended-materials in the grid, will "fill out" their respective part of the grid. - Skeletons / non-skeletons should be equally large. - That the content will not jump depending on the cover image frame. DDFFORM-490
LasseStaus
force-pushed
the
DDFFORM-490-material-grid
branch
from
cf36ac3 to
bf57224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
jira: DDFFORM-490
Changes in React related to this PR: danskernesdigitalebibliotek/dpl-react#1136
Description
This pr aims to address inconsistent layout before, during and after rendering a material grid consisting of multiple recommendedMaterial components.
Please do test this thoroughly by creating material grids in the CMS with the updated design system and react repo.
The issue was found on IOS devices, using safari browers, so make you also test that.
If you find any errors, please consider how they can be corrected.
Screenshot of the result
The issue before:
How it should look now generally on every device / browser.
