DDFFORM 490 material grid #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks a few things: - Ensure modifier class is applied to recommenedMaterialSkeletons that are part of grid view, like the non-skeleton component. - Ensure rendering of the title in the material grids. Before the skeleton would should a skeleton for the title, but since the title is always present if passed to the component, then this is unnessary/incorrect. - Add __icon class to the icon skeleton to ensure correct position. DDFFORM-490
kasperg
approved these changes
Apr 22, 2024
LasseStaus
force-pushed
the
DDFFORM-490-material-grid
branch
from
32e263a to
2871da2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
jira: DDFFORM-490
Changes in design system related to this PR: danskernesdigitalebibliotek/dpl-design-system#600
Description
This pr updates the skeleton rendering for the materialgrid, and the use of recommendedMaterialSkeleton as part of that.