Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logo into logo-link #621

Merged
merged 1 commit into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/stories/Blocks/header/Header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,12 @@ export const Header = (props: HeaderProps) => {
<>
<header className="header">
<div className="header__logo-desktop">
<a className="header__logo-desktop-link" href="/">
<Logo
fallback={false}
libraryName="Hjørring"
altText="PromoTitle image of libary"
/>
</a>
<Logo
hasImage
libraryName="Hjørring"
libraryPlace="Bibliotekerne"
altText="PromoTitle image of libary"
/>
</div>

<div className="header__menu">
Expand All @@ -71,8 +70,9 @@ export const Header = (props: HeaderProps) => {
</Pagefold>
<div className="header__menu-navigation-logo">
<Logo
fallback
hasImage
libraryName="Lyngby-Taarbæk"
libraryPlace="Bibliotekerne"
altText="PromoTitle image of libary"
/>
</div>
Expand Down
9 changes: 0 additions & 9 deletions src/stories/Blocks/header/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@
border-right: 1px solid $color__global-tertiary-1;
}

.header__logo-desktop-link {
text-decoration: none;
height: 100%;
width: 100%;
display: flex;
align-items: center;
justify-content: center;
}

.header__menu {
display: grid;
grid-template-rows: 1fr 1fr;
Expand Down
7 changes: 6 additions & 1 deletion src/stories/Library/footer-widgets/FooterWidgets.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@ const FooterWidgets: FC<FooterWidgetsType> = ({ footerLanguages }) => {
ariaLabel="dropdown"
arrowIcon="triangles"
/>
<Logo fallback={false} libraryName="" altText="logo" />
<Logo
hasImage
libraryName="Hjørring"
libraryPlace="Bibliotekerne"
altText="logo"
/>
</div>
);
};
Expand Down
28 changes: 11 additions & 17 deletions src/stories/Library/logo/Logo.stories.tsx
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
import { ComponentStory } from "@storybook/react";
import { withDesign } from "storybook-addon-designs";
import Logo, { LogoProps } from "./Logo";

export default {
title: "Library / Logo",
component: Logo,
decorators: [withDesign],
argTypes: {
libraryName: {
defaultValue: "Hjørring",
},
altText: {
defaultValue: "Logo",
},
},
parameters: {
design: {
type: "figma",
Expand All @@ -27,14 +17,18 @@ const Template: ComponentStory<typeof Logo> = (args: LogoProps) => (
<Logo {...args} />
);

export const Default = Template.bind({});
Default.args = {
fallback: false,
altText: "logo",
export const LogoWithImage = Template.bind({});
LogoWithImage.args = {
hasImage: true,
libraryName: "Hjørring",
libraryPlace: "Bibliotekerne",
altText: "Logo",
};

export const LogoFallback = Template.bind({});
LogoFallback.args = {
fallback: true,
export const LogoWithoutImage = Template.bind({});
LogoWithoutImage.args = {
hasImage: false,
libraryName: "Hjørring",
libraryPlace: "Bibliotekerne",
altText: "Logo",
};
31 changes: 18 additions & 13 deletions src/stories/Library/logo/Logo.tsx
Original file line number Diff line number Diff line change
@@ -1,24 +1,29 @@
import "../../../styles/css/base.css";
import clsx from "clsx";
import logo from "./logo.png";

export type LogoProps = {
fallback: boolean;
hasImage: boolean;
libraryName: string;
libraryPlace?: string;
altText: string;
};

const Logo = (props: LogoProps) => {
const { fallback, libraryName, altText } = props;

return fallback ? (
<div className="logo-fallback">
<p className="logo-fallback__text-name">{libraryName}</p>
<p className="logo-fallback__text-libraries">Bibliotekerne</p>
</div>
) : (
<div>
<img className="logo" src={logo} alt={altText} />
</div>
const Logo = ({ hasImage, libraryName, libraryPlace, altText }: LogoProps) => {
return (
<a href="/" className="logo" aria-label="Gå til forsiden">
<figure className="logo__content">
{hasImage && <img src={logo} alt={altText} />}
<div
className={clsx("logo__description", {
"logo__description--has-image": hasImage,
})}
>
<p className="logo__library-name">{libraryName}</p>
{libraryPlace && <p>{libraryPlace}</p>}
</div>
</figure>
</a>
);
};

Expand Down
27 changes: 18 additions & 9 deletions src/stories/Library/logo/logo.scss
Original file line number Diff line number Diff line change
@@ -1,30 +1,39 @@
.logo {
text-decoration: none;
height: 100%;
width: auto;
display: flex;
align-items: center;
justify-content: center;

img {
display: none;

height: 100px;
width: auto;

@include media-query__small {
display: block;
}
}
}

.logo-fallback {
.logo__description {
@include typography($typo__body-small);
}

.logo-fallback__text-name {
.logo__library-name {
font-weight: 700;
}

.logo-fallback__text-libraries {
font-weight: 300;
.logo__description--has-image {
@include media-query__small {
display: none;
}
}

.logo-fallback--has-image {
@include media-query__small {
.has-burger-menu .header__menu-navigation-mobile .logo {
img {
display: none;
}
.logo__description--has-image {
display: block;
}
}
Loading