Move more translations used globally to the global definition

danskernesdigitalebibliotek · Dec 16, 2023 · 995be70 · 995be70
1 parent dd6efd2
commit 995be70
Show file tree

Hide file tree

Showing 8 changed files with 21 additions and 27 deletions.
diff --git a/src/apps/dashboard/dashboard.dev.tsx b/src/apps/dashboard/dashboard.dev.tsx
@@ -84,10 +84,6 @@ export default {
       defaultValue: "Ready for you",
       control: { type: "text" }
     },
-    reservationsStillInQueueForText: {
-      defaultValue: "Still in queue",
-      control: { type: "text" }
-    },
     noPhysicalLoansText: {
       defaultValue: "At the moment, you have 0 physical loans",
       control: { type: "text" }

diff --git a/src/apps/dashboard/dashboard.entry.tsx b/src/apps/dashboard/dashboard.entry.tsx
@@ -52,7 +52,6 @@ export interface DashBoardProps {
   readyForLoanText: string;
   reservationDetailsOthersInQueueText: string;
   reservationsReadyText: string;
-  reservationsStillInQueueForText: string;
   reservationsText: string;
   resultPagerStatusText: string;
   statusBadgeWarningText: string;

diff --git a/src/apps/favorites-list/FavoritesList.dev.tsx b/src/apps/favorites-list/FavoritesList.dev.tsx
@@ -48,11 +48,6 @@ export default {
       defaultValue: "/work/:workid",
       control: { type: "text" }
     },
-    availabilityAvailableText: {
-      name: "Availability: available text",
-      defaultValue: "Available",
-      control: { type: "text" }
-    },
     favoritesListMaterialsText: {
       defaultValue: "@count materials",
       control: { type: "text" }

diff --git a/src/apps/favorites-list/FavoritesList.entry.tsx b/src/apps/favorites-list/FavoritesList.entry.tsx
@@ -12,7 +12,6 @@ interface FavoritesListConfigEntryProps {
   fbsBaseUrlConfig: string;
 }
 interface FavoritesListTextEntryProps {
-  availabilityAvailableText: string;
   favoritesListMaterialsText: string;
   favoritesListHeaderText: string;
   byAuthorText: string;

diff --git a/src/apps/material/material.dev.tsx b/src/apps/material/material.dev.tsx
@@ -54,11 +54,6 @@ export default {
         '[\n   {\n      "branchId":"DK-775120",\n      "title":"Højbjerg"\n   },\n   {\n      "branchId":"DK-775122",\n      "title":"Beder-Malling"\n   },\n   {\n      "branchId":"DK-775144",\n      "title":"Gellerup"\n   },\n   {\n      "branchId":"DK-775167",\n      "title":"Lystrup"\n   },\n   {\n      "branchId":"DK-775146",\n      "title":"Harlev"\n   },\n   {\n      "branchId":"DK-775168",\n      "title":"Skødstrup"\n   },\n   {\n      "branchId":"FBS-751010",\n      "title":"Arresten"\n   },\n   {\n      "branchId":"DK-775147",\n      "title":"Hasle"\n   },\n   {\n      "branchId":"FBS-751032",\n      "title":"Må ikke benyttes"\n   },\n   {\n      "branchId":"FBS-751031",\n      "title":"Fjernlager 1"\n   },\n   {\n      "branchId":"DK-775126",\n      "title":"Solbjerg"\n   },\n   {\n      "branchId":"FBS-751030",\n      "title":"ITK"\n   },\n   {\n      "branchId":"DK-775149",\n      "title":"Sabro"\n   },\n   {\n      "branchId":"DK-775127",\n      "title":"Tranbjerg"\n   },\n   {\n      "branchId":"DK-775160",\n      "title":"Risskov"\n   },\n   {\n      "branchId":"DK-775162",\n      "title":"Hjortshøj"\n   },\n   {\n      "branchId":"DK-775140",\n      "title":"Åby"\n   },\n   {\n      "branchId":"FBS-751009",\n      "title":"Fjernlager 2"\n   },\n   {\n      "branchId":"FBS-751029",\n      "title":"Stadsarkivet"\n   },\n   {\n      "branchId":"FBS-751027",\n      "title":"Intern"\n   },\n   {\n      "branchId":"FBS-751026",\n      "title":"Fælles undervejs"\n   },\n   {\n      "branchId":"FBS-751025",\n      "title":"Fællessekretariatet"\n   },\n   {\n      "branchId":"DK-775133",\n      "title":"Bavnehøj"\n   },\n   {\n      "branchId":"FBS-751024",\n      "title":"Fjernlånte materialer"\n   },\n   {\n      "branchId":"DK-775100",\n      "title":"Hovedbiblioteket"\n   },\n   {\n      "branchId":"DK-775170",\n      "title":"Trige"\n   },\n   {\n      "branchId":"DK-775150",\n      "title":"Tilst"\n   },\n   {\n      "branchId":"DK-775130",\n      "title":"Viby"\n   },\n   {\n      "branchId":"DK-775164",\n      "title":"Egå"\n   }\n]',
       control: { type: "text" }
     },
-    availabilityAvailableText: {
-      name: "Availability: available text",
-      defaultValue: "Available",
-      control: { type: "text" }
-    },
     materialHeaderAllEditionsText: {
       name: "Text for the fiction edition text",
       defaultValue: "All editions",

diff --git a/src/apps/material/material.entry.tsx b/src/apps/material/material.entry.tsx
@@ -12,7 +12,6 @@ interface MaterialEntryTextProps {
   addToFavoritesAriaLabelText: string;
   alreadyReservedText: string;
   approveReservationText: string;
-  availabilityAvailableText: string;
   blockedButtonText: string;
   cantReserveText: string;
   cantViewReviewText: string;

diff --git a/src/core/storybook/globalTextArgs.ts b/src/core/storybook/globalTextArgs.ts
@@ -18,6 +18,11 @@ export default {
     defaultValue: "Go to @label material details",
     control: { type: "text" }
   },
+  availabilityAvailableText: {
+    name: "Availability: available text",
+    defaultValue: "Available",
+    control: { type: "text" }
+  },
   availabilityUnavailableText: {
     name: "Availability: unavailable text",
     defaultValue: "Unavailable",
@@ -28,11 +33,11 @@ export default {
     control: { type: "text" }
   },
   patronContactInfoBodyText: {
-    defaultValue: "",
+    defaultValue: "Patron contact info body text",
     control: { type: "text" }
   },
   pauseReservationModalBelowInputsText: {
-    defaultValue: "",
+    defaultValue: "Pause reservation modal below inputs text",
     control: { type: "text" }
   },
   materialDetailsCloseModalAriaLabelText: {
@@ -45,6 +50,17 @@ export default {
     name: "Find on shelf expand button explanation text",
     defaultValue: "This button opens a modal",
     control: { type: "text" }
+  },
+  reservationsStillInQueueForText: {
+    defaultValue: "Still in queue",
+    control: { type: "text" }
+  },
+  materialDetailsModalAriaDescriptionText: {
+    defaultValue:
+      "This modal shows material details, and makes it possible to renew a material, of that material is renewable",
+    control: {
+      type: "text"
+    }
   }
 };
 
@@ -53,10 +69,13 @@ export interface GlobalEntryTextProps {
   alertErrorMessageText: string;
   multiselectAllOptionText: string;
   groupModalGoToMaterialAriaLabelText: string;
+  availabilityAvailableText: string;
   availabilityUnavailableText: string;
   loansNotOverdueText: string;
   patronContactInfoBodyText: string;
   pauseReservationModalBelowInputsText: string;
   materialDetailsCloseModalAriaLabelText: string;
   findOnShelfExpandButtonExplanationText: string;
+  reservationsStillInQueueForText: string;
+  materialDetailsModalAriaDescriptionText: string;
 }
diff --git a/src/core/storybook/materialDetailsModalArgs.ts b/src/core/storybook/materialDetailsModalArgs.ts
@@ -36,13 +36,6 @@ export default {
     },
     defaultValue: "Expired"
   },
-  materialDetailsModalAriaDescriptionText: {
-    control: {
-      type: "text"
-    },
-    defaultValue:
-      "This modal shows material details, and makes it possible to renew a material, of that material is renewable"
-  },
   materialDetailsGoToEreolenText: {
     defaultValue: "Go to eReolen",
     control: { type: "text" }
@@ -82,7 +75,6 @@ export interface MaterialDetailsModalProps {
   materialDetailsOverdueText: string;
   feesPageUrl: string;
   ereolenMyPageUrl: string;
-  materialDetailsModalAriaDescriptionText: string;
   materialDetailsGoToEreolenText: string;
   materialDetailsDigitalDueDateLabelText: string;
   materialDetailsRenewLoanButtonText: string;